Longitudinal preprocessor multithreading #373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipDeegan
force-pushed
the
longitudinal-preprocessor-parallelization
branch
from
cbd931a to
c9818f3
Compare
PhilipDeegan
force-pushed
the
longitudinal-preprocessor-parallelization
branch
3 times, most recently
from
c3313ae to
e61301f
Compare
MaryanMorel
approved these changes
Jun 26, 2019
Member
MaryanMorel
left a comment
MaryanMorel
left a comment
There was a problem hiding this comment.
Seems good to me! It'd be nice to put CooMatrix declaration in a separate file from the preprocessor though.
PhilipDeegan
force-pushed
the
longitudinal-preprocessor-parallelization
branch
from
25136c2 to
4ae90a7
Compare
PhilipDeegan
force-pushed
the
longitudinal-preprocessor-parallelization
branch
from
4ae90a7 to
45ff515
Compare
Member
|
Should probably have a test of some sort to validate they output the same things |
PhilipDeegan
force-pushed
the
longitudinal-preprocessor-parallelization
branch
from
45ff515 to
1175859
Compare
PhilipDeegan
force-pushed
the
longitudinal-preprocessor-parallelization
branch
from
1175859 to
c474299
Compare
uint to size_t oops updated swig updates for single swig header include directory template init move coo_matrix to array headers
PhilipDeegan
force-pushed
the
longitudinal-preprocessor-parallelization
branch
from
c474299 to
f8a713d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multithreading for Longitudinal Features Lagger