Draft
Conversation
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
…p_internal` If we can't directly import a bo from an EGLImage, export the image as dmabufs and import a bo from dmabufs. Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
… reuse Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
… supported If there is not even one (format, modifier) pair, then glamor cannot function. This allows drivers, notably modesetting, to detect early that glamor cannot be used, and fall back to something else. Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
It isn't actually useful for now. Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
force-pushed
the
more-egl-platforms-v3
branch
from
2582d08 to
2c528c0
Compare
Not used anywhere Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
force-pushed
the
more-egl-platforms-v3
branch
from
1d660de to
93fc249
Compare
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
force-pushed
the
more-egl-platforms-v3
branch
from
93fc249 to
af92de7
Compare
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
force-pushed
the
more-egl-platforms-v3
branch
from
2ba2d46 to
c6c5107
Compare
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
…latform Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
force-pushed
the
more-egl-platforms-v3
branch
from
e2c8503 to
95937d4
Compare
… compat with drivers Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
force-pushed
the
more-egl-platforms-v3
branch
from
c30443c to
6dd5780
Compare
This extension is not available with the 390 nvidia driver Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
requested review from
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
josephcrowell and
metux
Contributor
Author
|
@notbabaisyou ping |
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
|
Merge Conflict found |
2 similar comments
|
Merge Conflict found |
|
Merge Conflict found |
stefan11111
added a commit
to stefan11111/xserver
that referenced
this pull request
Apr 17, 2026
With this, glamor_egl now tries the platforms
`EGL_PLATFORM_GBM_{KHR,MESA}`, `EGL_PLATFORM_DEVICE_EXT`,
and `EGL_PLATFORM_SURFACELESS_MESA`
`EGL_PLATFORM_SURFACELESS_MESA` is used as a fallback,
and is probably not very useful in practice, since if
it is supported, the GBM or Device platform is probably
also supported.
After it, we try all platforms with `EGL_DEFAULT_DISPLAY`
as the `native_display` argument.
Like Surfaceless, there are probably not very useful, and are
there as a last-resort fallback path if we're sure they cannot
break anything.
These fallbacks only take up 6 extra lines of code (excluding comments),
and they allow us to be robust with our fallback paths.
The interesting platform in this patch is `EGL_PLATFORM_DEVICE_EXT`
This one can be used without a dri fd, and is the only plaform
supported on old nvidia cards (<= nvidia-470), regardless of whether
a dri fd is passed or not.
As a side note, while I don't currently have any
concete plans, this is a step forward towards `EGLStream` support.
A further patch will add support for the nvidia-390 driver,
since it does not support `EGL_KHR_no_config_context`,
which glamor currently requires.
Though not very useful, here are the previous iterations
of the patch:
v3: X11Libre#2083
v2: X11Libre#1758
v1: X11Libre#1729
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
added a commit
to stefan11111/xserver
that referenced
this pull request
Apr 17, 2026
With this, glamor_egl now tries the platforms
`EGL_PLATFORM_GBM_{KHR,MESA}`, `EGL_PLATFORM_DEVICE_EXT`,
and `EGL_PLATFORM_SURFACELESS_MESA`
`EGL_PLATFORM_SURFACELESS_MESA` is used as a fallback,
and is probably not very useful in practice, since if
it is supported, the GBM or Device platform is probably
also supported.
After it, we try all platforms with `EGL_DEFAULT_DISPLAY`
as the `native_display` argument.
Like Surfaceless, there are probably not very useful, and are
there as a last-resort fallback path if we're sure they cannot
break anything.
These fallbacks only take up 6 extra lines of code (excluding comments),
and they allow us to be robust with our fallback paths.
The interesting platform in this patch is `EGL_PLATFORM_DEVICE_EXT`
This one can be used without a dri fd, and is the only plaform
supported on old nvidia cards (<= nvidia-470), regardless of whether
a dri fd is passed or not.
As a side note, while I don't currently have any
concete plans, this is a step forward towards `EGLStream` support.
A further patch will add support for the nvidia-390 driver,
since it does not support `EGL_KHR_no_config_context`,
which glamor currently requires.
Though not very useful, here are the previous iterations
of the patch:
v3: X11Libre#2083
v2: X11Libre#1758
v1: X11Libre#1729
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
added a commit
to stefan11111/xserver
that referenced
this pull request
Apr 17, 2026
With this, glamor_egl now tries the platforms
`EGL_PLATFORM_GBM_{KHR,MESA}`, `EGL_PLATFORM_DEVICE_EXT`,
and `EGL_PLATFORM_SURFACELESS_MESA`
`EGL_PLATFORM_SURFACELESS_MESA` is used as a fallback,
and is probably not very useful in practice, since if
it is supported, the GBM or Device platform is probably
also supported.
After it, we try all platforms with `EGL_DEFAULT_DISPLAY`
as the `native_display` argument.
Like Surfaceless, there are probably not very useful, and are
there as a last-resort fallback path if we're sure they cannot
break anything.
These fallbacks only take up 6 extra lines of code (excluding comments),
and they allow us to be robust with our fallback paths.
The interesting platform in this patch is `EGL_PLATFORM_DEVICE_EXT`
This one can be used without a dri fd, and is the only plaform
supported on old nvidia cards (<= nvidia-470), regardless of whether
a dri fd is passed or not.
As a side note, while I don't currently have any
concete plans, this is a step forward towards `EGLStream` support.
A further patch will add support for the nvidia-390 driver,
since it does not support `EGL_KHR_no_config_context`,
which glamor currently requires.
For related Xwayland `EGLStream` code, see:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/feb35a2e6b0357bcbdb77ad10c3b8285c0e2f055
Though not very useful, here are the previous iterations
of the patch:
v3: X11Libre#2083
v2: X11Libre#1758
v1: X11Libre#1729
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
added a commit
to stefan11111/xserver
that referenced
this pull request
Apr 17, 2026
With this, glamor_egl now tries the platforms
`EGL_PLATFORM_GBM_{KHR,MESA}`, `EGL_PLATFORM_DEVICE_EXT`,
and `EGL_PLATFORM_SURFACELESS_MESA`
`EGL_PLATFORM_SURFACELESS_MESA` is used as a fallback,
and is probably not very useful in practice, since if
it is supported, the GBM or Device platform is probably
also supported.
After it, we try all platforms with `EGL_DEFAULT_DISPLAY`
as the `native_display` argument.
Like Surfaceless, there are probably not very useful, and are
there as a last-resort fallback path if we're sure they cannot
break anything.
These fallbacks only take up 6 extra lines of code (excluding comments),
and they allow us to be robust with our fallback paths.
The interesting platform in this patch is `EGL_PLATFORM_DEVICE_EXT`
This one can be used without a dri fd, and is the only plaform
supported on old nvidia cards (<= nvidia-470), regardless of whether
a dri fd is passed or not.
As a side note, while I don't currently have any
concete plans, this is a step forward towards `EGLStream` support.
A further patch will add support for the nvidia-390 driver,
since it does not support `EGL_KHR_no_config_context`,
which glamor currently requires.
For related Xwayland `EGLStream` code, see:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/feb35a2e6b0357bcbdb77ad10c3b8285c0e2f055
Though not very useful, here are the previous iterations
of the patch:
v3: X11Libre#2083
v2: X11Libre#1758
v1: X11Libre#1729
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
added a commit
to stefan11111/xserver
that referenced
this pull request
Apr 17, 2026
With this, glamor_egl now tries the platforms
`EGL_PLATFORM_GBM_{KHR,MESA}`, `EGL_PLATFORM_DEVICE_EXT`,
and `EGL_PLATFORM_SURFACELESS_MESA`
`EGL_PLATFORM_SURFACELESS_MESA` is used as a fallback,
and is probably not very useful in practice, since if
it is supported, the GBM or Device platform is probably
also supported.
After it, we try all platforms with `EGL_DEFAULT_DISPLAY`
as the `native_display` argument.
Like Surfaceless, there are probably not very useful, and are
there as a last-resort fallback path if we're sure they cannot
break anything.
These fallbacks only take up 6 extra lines of code (excluding comments),
and they allow us to be robust with our fallback paths.
The interesting platform in this patch is `EGL_PLATFORM_DEVICE_EXT`
This one can be used without a dri fd, and is the only plaform
supported on old nvidia cards (<= nvidia-470), regardless of whether
a dri fd is passed or not.
As a side note, while I don't currently have any
concete plans, this is a step forward towards `EGLStream` support.
A further patch will add support for the nvidia-390 driver,
since it does not support `EGL_KHR_no_config_context`,
which glamor currently requires.
For related Xwayland `EGLStream` code, see:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/feb35a2e6b0357bcbdb77ad10c3b8285c0e2f055
Though not very useful, here are the previous iterations
of the patch:
v3: X11Libre#2083
v2: X11Libre#1758
v1: X11Libre#1729
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
added a commit
to stefan11111/xserver
that referenced
this pull request
Apr 17, 2026
With this, glamor_egl now tries the platforms
`EGL_PLATFORM_GBM_{KHR,MESA}`, `EGL_PLATFORM_DEVICE_EXT`,
and `EGL_PLATFORM_SURFACELESS_MESA`
`EGL_PLATFORM_SURFACELESS_MESA` is used as a fallback,
and is probably not very useful in practice, since if
it is supported, the GBM or Device platform is probably
also supported.
After it, we try all platforms with `EGL_DEFAULT_DISPLAY`
as the `native_display` argument.
Like Surfaceless, there are probably not very useful, and are
there as a last-resort fallback path if we're sure they cannot
break anything.
These fallbacks only take up 6 extra lines of code (excluding comments),
and they allow us to be robust with our fallback paths.
The interesting platform in this patch is `EGL_PLATFORM_DEVICE_EXT`
This one can be used without a dri fd, and is the only plaform
supported on old nvidia cards (<= nvidia-470), regardless of whether
a dri fd is passed or not.
As a side note, while I don't currently have any
concete plans, this is a step forward towards `EGLStream` support.
A further patch will add support for the nvidia-390 driver,
since it does not support `EGL_KHR_no_config_context`,
which glamor currently requires.
For related Xwayland `EGLStream` code, see:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/feb35a2e6b0357bcbdb77ad10c3b8285c0e2f055
Though not very useful, here are the previous iterations
of the patch:
v3: X11Libre#2083
v2: X11Libre#1758
v1: X11Libre#1729
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
added a commit
to stefan11111/xserver
that referenced
this pull request
Apr 17, 2026
With this, glamor_egl now tries the platforms
`EGL_PLATFORM_GBM_{KHR,MESA}`, `EGL_PLATFORM_DEVICE_EXT`,
and `EGL_PLATFORM_SURFACELESS_MESA`
`EGL_PLATFORM_SURFACELESS_MESA` is used as a fallback,
and is probably not very useful in practice, since if
it is supported, the GBM or Device platform is probably
also supported.
After it, we try all platforms with `EGL_DEFAULT_DISPLAY`
as the `native_display` argument.
Like Surfaceless, there are probably not very useful, and are
there as a last-resort fallback path if we're sure they cannot
break anything.
These fallbacks only take up 6 extra lines of code (excluding comments),
and they allow us to be robust with our fallback paths.
The interesting platform in this patch is `EGL_PLATFORM_DEVICE_EXT`
This one can be used without a dri fd, and is the only plaform
supported on old nvidia cards (<= nvidia-470), regardless of whether
a dri fd is passed or not.
As a side note, while I don't currently have any
concete plans, this is a step forward towards `EGLStream` support.
A further patch will add support for the nvidia-390 driver,
since it does not support `EGL_KHR_no_config_context`,
which glamor currently requires.
For related Xwayland `EGLStream` code, see:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/feb35a2e6b0357bcbdb77ad10c3b8285c0e2f055
Though not very useful, here are the previous iterations
of the patch:
v3: X11Libre#2083
v2: X11Libre#1758
v1: X11Libre#1729
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
stefan11111
added a commit
to stefan11111/xserver
that referenced
this pull request
Apr 17, 2026
With this, glamor_egl now tries the platforms
`EGL_PLATFORM_GBM_{KHR,MESA}`, `EGL_PLATFORM_DEVICE_EXT`,
and `EGL_PLATFORM_SURFACELESS_MESA`
`EGL_PLATFORM_SURFACELESS_MESA` is used as a fallback,
and is probably not very useful in practice, since if
it is supported, the GBM or Device platform is probably
also supported.
After it, we try all platforms with `EGL_DEFAULT_DISPLAY`
as the `native_display` argument.
Like Surfaceless, there are probably not very useful, and are
there as a last-resort fallback path if we're sure they cannot
break anything.
These fallbacks only take up 6 extra lines of code (excluding comments),
and they allow us to be robust with our fallback paths.
The interesting platform in this patch is `EGL_PLATFORM_DEVICE_EXT`
This one can be used without a dri fd, and is the only plaform
supported on old nvidia cards (<= nvidia-470), regardless of whether
a dri fd is passed or not.
As a side note, while I don't currently have any
concete plans, this is a step forward towards `EGLStream` support.
A further patch will add support for the nvidia-390 driver,
since it does not support `EGL_KHR_no_config_context`,
which glamor currently requires.
For related Xwayland `EGLStream` code, see:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/feb35a2e6b0357bcbdb77ad10c3b8285c0e2f055
Though not very useful, here are the previous iterations
of the patch:
v3: X11Libre#2083
v2: X11Libre#1758
v1: X11Libre#1729
Signed-off-by: stefan11111 <stefan11111@shitposting.expert>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A combination of #1758 and the glamor code from Xfbdev.
With this, hw acceleration works on 470 and 390 cards with the modesetting driver.
From my testing, performance is slightly better than in Xfbdev, but not the same as what I get with the 580 driver with dri enabled.
I only tested this with me gtx 1050, with the 470 and 390 drivers. I don't have an older card to test with.