Remove hyperx dep; Manually inspect 'Link' header#258
Merged
XAMPPRocky merged 2 commits intoXAMPPRocky:masterfrom Mar 21, 2023
lpotthast:remove-hyperx
Merged
Remove hyperx dep; Manually inspect 'Link' header#258XAMPPRocky merged 2 commits intoXAMPPRocky:masterfrom lpotthast:remove-hyperx
XAMPPRocky merged 2 commits intoXAMPPRocky:masterfrom
lpotthast:remove-hyperx
Conversation
|
Please follow up this PR, this branch works fine. I have encountered some dependency conflicts of |
|
Thanks - I have tested this and it does seem to fix my dependency conflict relating to My workaround is setting my Which allows me to move compile and move forward for now... |
Owner
|
Thank you for your PR, and congrats on your first contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated multiple times in #110, the existence of the
hyperxdependency causes more trouble than it brings functionality.This PR removes the dependency altogether, replacing the small bits which were actually used with some custom logic.
Note:
Alternatively to merging this, one could hope that merging dekellum/hyperx#40 will resolve all our problems...