-
Notifications
You must be signed in to change notification settings - Fork 105
Subscribe: Add book_changes
#839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA new member, Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
xrpl/models/requests/subscribe.py (2)
21-33
: Add unit tests for the new stream parameter.
To ensureBOOK_CHANGES
is properly serialized and handled by clients, please add unit tests that cover usingStreamParameter.BOOK_CHANGES
in a subscribe request—validating the JSON payload and any downstream behavior.
22-24
: Update docstring to mentionbook_changes
.
Consider enhancing the class-level docstring (or related documentation) to explicitly listbook_changes
as a supported stream, so users are aware of this new option.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
xrpl/models/requests/subscribe.py
(1 hunks)
🔇 Additional comments (1)
xrpl/models/requests/subscribe.py (1)
24-24
: Approve addition ofBOOK_CHANGES
enum member.
The newStreamParameter.BOOK_CHANGES = "book_changes"
correctly extends the enum to support thebook_changes
stream.
Hi, if this PR is ready please add a description with context for the change and mark it as "ready" instead of draft. If you are still working on it, no worries. |
High Level Overview of Change
Context of Change
Type of Change
Did you update CHANGELOG.md?
Test Plan