Fix ClearFlag CLI flag mapping#313
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix
Fix ClearFlag CLI flag mapping
May 24, 2026
ClearFlag CLI to correctly clear account flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
xrpl account clear-flagwas wiring the requested flag intoset_flag, so the CLI did the opposite of the user intent. This corrects the transaction construction and adds a regression check for the emittedAccountSetfields.Context of Change
The bug was in the
ClearFlagCLI path: a clear request could serialize as a flag set, includingasfDisableMaster, which can lock an account out of master-key authorization.Type of Change
Before / After
SetFlagpath stays unchanged.ClearFlagnow populatesclear_flagand leavesset_flagunset.ClearFlagis presentSetFlagis absentTest Plan
cargo test --features "std cli integration" --test cli_integration test_account_clear_flag -- --nocapturecargo test --features "std cli integration" --test cli_integration test_account_set_flag -- --nocapture