fix(#167): locate XChainOwnedClaimID by type, not by index#317
Open
LeJamon wants to merge 1 commit into
Open
Conversation
AffectedNodes ordering is not guaranteed by the server. Replace the positional affected_nodes[0] lookup with a find_map that returns the created XChainOwnedClaimID entry carrying an xchain_claim_id, regardless of its position in the metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167.
get_xchain_claim_idreturned the claim id fromaffected_nodes[0]after filtering by type.AffectedNodesordering is not guaranteed by the server, and the first matching created node is not guaranteed to be the one carrying the field.Replaces the positional lookup with a
find_mapthat returns the first createdXChainOwnedClaimIDentry actually carrying anxchain_claim_id, regardless of position.Testing
cargo test --lib— addedtest_get_xchain_claim_id_not_first_node; existing tests still passcargo fmt --check; no_std feature set green