fix(#169): preserve WS Close reason and reply to the handshake#319
Open
LeJamon wants to merge 1 commit into
Open
fix(#169): preserve WS Close reason and reply to the handshake#319LeJamon wants to merge 1 commit into
LeJamon wants to merge 1 commit into
Conversation
On receiving a Close frame both the Stream adapter and request_impl discarded the frame and reported a bare Disconnected error. Capture the peer's close code and reason into a new ConnectionClosed error, and reply with a Close frame in request_impl to complete the RFC 6455 handshake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169.
On receiving a WebSocket Close frame, both the
Streamadapter andrequest_impldiscarded the frame and returned a bareDisconnectederror, andrequest_implsent no Close reply.This captures the peer's close code and reason into a new
ConnectionClosed(reason)error, and replies with a Close frame inrequest_implto complete the RFC 6455 closing handshake. (tokio-tungstenite already echoes the Close internally for theStreampath.)Testing
cargo test --lib— addedclose_reason_preserves_peer_detailandclose_reason_handles_missing_framecargo fmt --check; no_std feature set green