fix(#171): resolve is_open from a type-state trait, not type_name#320
Open
LeJamon wants to merge 1 commit into
Open
fix(#171): resolve is_open from a type-state trait, not type_name#320LeJamon wants to merge 1 commit into
LeJamon wants to merge 1 commit into
Conversation
is_open compared core::any::type_name strings, which are explicitly not stable across compiler releases. Introduce a sealed ConnectionStatus trait with a const IS_OPEN implemented for WebSocketOpen/WebSocketClosed and have is_open return Status::IS_OPEN, resolved at compile time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #171.
is_open()comparedcore::any::type_name::<Status>()against a hardcoded string.type_nameis explicitly documented as unstable across compiler releases, making the connection-state check fragile.Introduces a sealed
ConnectionStatustrait with aconst IS_OPEN, implemented forWebSocketOpen/WebSocketClosed;is_open()returnsStatus::IS_OPEN, resolved at compile time.Testing
cargo test --lib— addedconnection_status_is_open_resolves_from_type_statecargo fmt --check; no_std feature set green