fix(#173): reject non-ASCII NFT IDs before byte slicing#322
Open
LeJamon wants to merge 1 commit into
Open
Conversation
parse_nftoken_id length-checks by byte count and then slices nft_id at fixed byte offsets. A 64-byte string containing multibyte UTF-8 could land a slice boundary mid-character and panic. Guard with an is_ascii() check that returns the new InvalidNFTIdEncoding error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173.
parse_nftoken_idlength-checks by byte count and then slicesnft_idat fixed byte offsets ([0..4],[48..56], ...). A 64-byte string containing multibyte UTF-8 could land a slice boundary mid-character and panic.Adds an
is_ascii()guard before slicing, returning the newXRPLNFTIdException::InvalidNFTIdEncodingfor non-ASCII input.Testing
cargo test --lib— addedtest_parse_nftoken_id_non_ascii_returns_err_without_panic(a 64-byte input that previously panicked)cargo fmt --check; no_std feature set green