Implement LocalFileTimeToFileTime#766
Closed
antonic901 wants to merge 1 commit into
Closed
Conversation
Ryzee119
reviewed
Feb 23, 2026
| localFileTime.LowPart = lpLocalFileTime->dwLowDateTime; | ||
| localFileTime.HighPart = lpLocalFileTime->dwHighDateTime; | ||
|
|
||
| // Adjust the file time by the timezone offset. This function does not account for DST. |
Contributor
There was a problem hiding this comment.
This comment doesnt apply to LocalFileTimeToFileTime
See MSDocs https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-localfiletimetofiletime
LocalFileTimeToFileTime uses the current settings for the time zone and daylight saving time. Therefore, if it is daylight saving time, this function will take daylight saving time into account, even if the time you are converting is in standard time.
Contributor
|
Generally our commit name convention is |
antonic901
changed the title
antonic901
force-pushed
the
localfiletime-to-filetime
branch
from
a680aa4 to
33c5723
Compare
antonic901
changed the title
antonic901
force-pushed
the
localfiletime-to-filetime
branch
from
33c5723 to
77706e6
Compare
Author
|
Update commit with proper message. Removed that comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be reverse of FileTimeToLocalFileTime, so here is imlpementation.