xboxkrnl: Build import library from def-file#776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the prebuilt
libxboxkrnl.libimport library, and instead usesllvm-dlltoolto generate it fromxboxkrnl.exe.def.The more ideal approach would be to use
llvm-lib, which has gained the ability to create import libraries from .def-files since last we experimented with this, but it generates incorrect symbol names (it doesn't add the underscore prefix to names that have anstdcalldecoration suffix, whichlib.exedoes).While that could and should get fixed upstream, we'd need to wait until a fixed LLVM version is sufficiently widespread, so I prefer to use
llvm-dlltoolfor now instead, which seems to work just fine.Fixes #119