Codeshared cen and chi e_breakable
#2933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hohle
reviewed
Oct 24, 2025
Comment on lines
+12
to
+16
| enum OVL_EXPORT(Palette) { | ||
| PAL_NONE = 0, | ||
| PAL_BREAKABLE_DEBRIS = 0x159, | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
Won't all OVL_DRA palettes (anything without the top bit set) be shared? This could be moved to include since I think it's universal.
Contributor
Author
There was a problem hiding this comment.
No, not all non-8XXX palettes will be shared, only at most 0x100-0x1FF. That being said, there hasn't been a word either way. I'm not against adjusting this however is best, the enum is just the last word I've gotten..
hohle
reviewed
Oct 24, 2025
Xeeynamo
reviewed
Oct 24, 2025
Xeeynamo
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.