Skip to content

[CAP-311] FIX: (BE) Notification Service MarkAllRead Hotfix#203

Merged
hatudoggy merged 1 commit into
developfrom
fix/cap-311/notification-mark-done-fix
Nov 6, 2025
Merged

[CAP-311] FIX: (BE) Notification Service MarkAllRead Hotfix#203
hatudoggy merged 1 commit into
developfrom
fix/cap-311/notification-mark-done-fix

Conversation

@hatudoggy

Copy link
Copy Markdown
Collaborator

This pull request updates the notifications system to ensure that when marking all notifications as read, it considers both the user's ID and their role. The main change is that notifications relevant to a user's role are now included, improving accuracy and relevance for users with different roles.

Notifications filtering improvements:

  • The markAllAsRead method in NotificationsService now accepts both userId and role, and filters notifications to include those either directly addressed to the user or relevant to their role.
  • The controller method markAllAsRead in NotificationsController now passes both user_id and role to the service, ensuring role-based notification filtering.

Documentation and method signature updates:

  • Updated the documentation for markAllAsRead to include the new role parameter.

@hatudoggy
hatudoggy requested a review from Copilot November 6, 2025 06:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the markAllAsRead functionality to filter notifications based on the user's role, ensuring that only relevant notifications are marked as read. The change adds role-based filtering to match the pattern used in other notification methods like findAll and getCount.

Key changes:

  • Added role parameter to the markAllAsRead method in both the controller and service
  • Implemented WHERE clause filtering to fetch only notifications relevant to the user's role
  • Updated JSDoc documentation to reflect the new parameter

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
backend/src/modules/notifications/notifications.service.ts Added role parameter and role-based filtering logic to markAllAsRead method
backend/src/modules/notifications/notifications.controller.ts Extracted role from user metadata and passed it to the service method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backend/src/modules/notifications/notifications.service.ts
Comment thread backend/src/modules/notifications/notifications.service.ts
@hatudoggy
hatudoggy merged commit 87ee228 into develop Nov 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants