Add ENCRYPTED PRIVATE KEY and OpenVPN patterns to PrivateKeyDetector#957
Open
Vignesh-Kathirkamar wants to merge 4 commits into
Open
Add ENCRYPTED PRIVATE KEY and OpenVPN patterns to PrivateKeyDetector#957Vignesh-Kathirkamar wants to merge 4 commits into
Vignesh-Kathirkamar wants to merge 4 commits into
Conversation
Vignesh-Kathirkamar
commented
May 12, 2026
- Please check if the PR fulfills these requirements
- Tests for the changes have been added
- Docs have been added / updated
- All CI checks are green
- What kind of change does this PR introduce?
- What is the current behavior?
- What is the new behavior (if this is a feature change)?
- Does this PR introduce a breaking change?
- Other information:
Add two missing private key patterns to achieve parity with pre-commit/pre-commit-hooks detect-private-key hook: - BEGIN ENCRYPTED PRIVATE KEY (PKCS#8 encrypted format) - BEGIN OpenVPN Static key V1 Per discussion in Yelp#70, encrypted private keys should still be flagged since passphrase strength cannot be verified by static analysis. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Add ENCRYPTED PRIVATE KEY and OpenVPN patterns to PrivateKeyDetector
Update the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.