converted to using estimationmode instead of boolean for estimation mode (mt1 , mt2)#12
Merged
thenetworkgrinch merged 3 commits intoYet-Another-Software-Suite:mainfrom Oct 12, 2025
Conversation
thenetworkgrinch
approved these changes
Oct 12, 2025
Contributor
thenetworkgrinch
left a comment
thenetworkgrinch
left a comment
There was a problem hiding this comment.
I appreciate reviewing this first. Thank you!
thenetworkgrinch
merged commit 82f2c96
into
Yet-Another-Software-Suite:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to improve code readibty and ease of use, since just reading boolean parameters for a constructor / function is much harder to understand the meaning of compared to
EstimationMode.MEGATAG2