Several improvements on ynh-dev script #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophehenry
commented
Feb 16, 2025
| @@ -2,6 +2,12 @@ | |||
|
|
|||
| # shellcheck disable=SC2155,SC2034,SC2164 | |||
|
|
|||
| if (( $(lsb_release -rs) >= 12 )); then | |||
| YARN_CMD=yarnpkg | |||
There was a problem hiding this comment.
On Debian 12+, the package seems to be yarnpkg and yarn seems to correspond to cmdtest.
christophehenry
force-pushed
the
improvements
branch
3 times, most recently
from
6f2aaef to
9f66625
Compare
christophehenry
commented
Feb 16, 2025
| cd "$DEV_PATH" | ||
| systemctl start yunohost-api |
There was a problem hiding this comment.
That's weird. When working with the container, yunohost-api seems not started and it creates problems when developing the front.
christophehenry
commented
Feb 16, 2025
| # Inject container ip in .env file | ||
| # Used by vite to expose itself on network and proxy api requests. | ||
| echo "VITE_IP=$(hostname -I | tr ' ' '\n' | grep "\.")" > "$DEV_PATH/.env" | ||
| create_sym_link "$DEV_PATH/.env" "$CACHE_PATH/.env" |
There was a problem hiding this comment.
The .env file seemedto never contained the correct IP. I hope sourcing it at the very last moment fixes it.
christophehenry
force-pushed
the
improvements
branch
from
9f66625 to
5a97f37
Compare
- Use command yarnpkg on Debian 12+ - Add --skip-yarn-install option to use-git subcommand to skip installing NPM deps in the container - Add use -y on apt command to avoid asking confirmation when installing yarn - Always 'systemctl start yunohost-api' on 'use-git yunohost-admin' - Fix Python script to add 8080 in allowed ports - 'set -e -o pipefail' to better catch this kind of errors - Always install dependencies from control file when 'use-git yunohost'
christophehenry
force-pushed
the
improvements
branch
from
5a97f37 to
d0c7b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skip-yarn-installoption to use-git subcommand to skip installing NPM deps in the containersystemctl start yunohost-apionuse-git yunohost-admin