Skip to content

add(RPC): Support Sapling tree roots in gbt RPC#10176

Draft
upbqdn wants to merge 64 commits into
mainfrom
refactor-gbt-roots
Draft

add(RPC): Support Sapling tree roots in gbt RPC#10176
upbqdn wants to merge 64 commits into
mainfrom
refactor-gbt-roots

Conversation

@upbqdn
Copy link
Copy Markdown
Member

@upbqdn upbqdn commented Dec 2, 2025

Motivation

Solution

Tests

Specifications & References

Follow-up Work

PR Checklist

  • The PR name is suitable for the release notes.
  • The PR follows the contribution guidelines.
  • The library crate changelogs are up to date.
  • The solution is tested.
  • The documentation is up to date.

upbqdn added 30 commits November 23, 2025 12:19
@upbqdn
Implement AsRef<[u8; 32]> for Hash
6b43753
@upbqdn
Impl From<&[u8; 32]> for Hash
057e55d
@upbqdn
Update librustzcash dependencies to construct-coinbase-txs branch
3320380
@upbqdn
Implement TryFrom<&[u8]> for AuthDigest
18136d7
@upbqdn
Add TryFrom<Address> implementation for TransparentAddress
82d7ff9
@upbqdn
Update deps zebra-rpc/Cargo.toml
50bc9c6
@upbqdn
Update TransparentAddress import to use zcash_transparent crate
7d95a5d
@upbqdn
Make zebra-chain::transparent::Address Copy
a809c38
@upbqdn
Reorder imports
535d5d1
@upbqdn
Add DefaultRoots::from_coinbase to construct roots from coinbase
60ea10a
@upbqdn
Switch to tx builder in zcash primitives
936531a
@upbqdn
Refactor and expand coinbase transaction generation tests
12e2f56
@upbqdn
Remove unused fake_coinbase_transaction function from zip317 module
bfc5148
@upbqdn
Remove unused calculate_miner_fee function from get_block_template
b391256
@upbqdn
Remove unused standard_coinbase_outputs function from get_block_template
cc86ed2
@upbqdn
Remove unused calculate_default_root_hashes function
ed8b1d1 
The function was no longer referenced and its removal simplifies the
code.
@upbqdn
Update block template snapshots
6f286a9
@upbqdn
Cosmetics
7f59351 
Replaced variables referencing network upgrades with direct enum usage
for clarity. Reformatted async trait method for consistent indentation.
No functional changes.
@upbqdn
Remove unused imports from get_block_template module
7023d7c
@upbqdn
Simplify comments
e47e634
@upbqdn
Support shielded coinbase outputs
c8822a3
@upbqdn
Remove obsolete TODO comment about internal miner config code
ea52a70
@upbqdn
Rename extra_coinbase_data to miner_data
5c8d2a8
@upbqdn
Add support for miner_memo in config and shielded coinbase transactions
da6990a
@upbqdn
Rename variable miner_address to miner_addr in getblocktemplate method
336f499
@upbqdn
Update snapshots
36528e0
@upbqdn
Remove old transaction builder module and coinbase input constructor
50dbe78
@upbqdn
Move error enum doc comment above the attribute and update formatting
f73bf72
@upbqdn
Add anyhow, strum, and strum_macros dependencies to Cargo.toml
ae0fe30
@upbqdn
Add coinbase variant to SerializationError and implement From trait
a58b085
upbqdn and others added 24 commits November 23, 2025 12:19
@upbqdn
Refactor test configs to remove unnecessary Result
e5eff7b
@upbqdn
Remove obsolete comment about coinbase transaction inputs
cd0b2ce
@upbqdn
Clarify doc comment for coinbase transaction constructor
9b5115a
@upbqdn
Refactor builder build call to use Default for empty arguments
4d90d51
@upbqdn
Rename e to err
2c6c19c 
Simplifies formatting and improves clarity by using {err} syntax.
@upbqdn
Remove MinerData and update coinbase script handling
bf9fdd8
@upbqdn
Refactor coinbase error handling to use TransactionError type
e938c44 
Replaces generic errors with TransactionError::CoinbaseConstruction for
clarity and consistency in coinbase transaction construction failures.
@upbqdn
Add regtest coinbase transaction validity test for Zebra blocks
1526320
@upbqdn
Simplify conversion to Zatoshis
d79da28
@upbqdn
Update to new lrz version
f2562d3
@upbqdn
Update deny.toml
2b1f51e
@upbqdn
Add Coinbase error mapping and remove unused serde_with import
e46ef88
@upbqdn
Fix generating block_commitments_hash
1c49edb
@upbqdn
Add zcash_primitives zip-233 feature to tx_v6 configuration
2b8c024
@upbqdn
Fix tx_v6 feature imports and zip233_amount handling in RPC methods
0225279
@upbqdn
Update tx_v6 feature gating to require nu7 unstable flag
191cd85
@upbqdn
Return quickly from gbt on chain tip change with precomputed coinbase tx
f16f522
@upbqdn
Simplify Commitment::from_bytes
c30da7c
@upbqdn
Rename Commitment::from_bytes to from_bytes_in_serialized_order
a339aeb
@upbqdn
Refactor chain info retrieval to simplify match handling
56afd79
@upbqdn
Remove fetch_chain_info helper and use direct ChainInfo request
dad4e36
@upbqdn
Simplify obtaining gbt chain info
5e15764
@upbqdn
Add Sapling root to chain info
19a94a8
@upbqdn
Refactor block template roots handling
b4f4ff3
@upbqdn upbqdn self-assigned this Dec 2, 2025
@conradoplg conradoplg added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Jan 20, 2026
@oxarbitrage oxarbitrage added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Mar 11, 2026
@arya2 arya2 added the do-not-merge Tells Mergify not to merge this PR label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@upbqdn upbqdn

Labels

do-not-merge Tells Mergify not to merge this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Sapling note commitment tree roots in gbt RPC

4 participants

@upbqdn @conradoplg @arya2 @oxarbitrage