fix(state): correct dequeue_children by_height index handling#10604
Open
syszery wants to merge 1 commit into
Open
fix(state): correct dequeue_children by_height index handling#10604syszery wants to merge 1 commit into
syszery wants to merge 1 commit into
Conversation
Contributor
|
Thank you for this PR. We will take a look shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes incorrect behavior in
QueuedBlocks::dequeue_childrenwhere removing queued children incorrectly removed entireby_heightbuckets instead of only the matching block hash.Closes #10597
Solution
Update
dequeue_childrento remove only the specific block hash from theby_heightindex, and only remove the height entry when no hashes remain.Tests
Added a regression test that constructs a forked chain scenario where two queued blocks exist at the same height but belong to different parents. The test fails on the previous implementation and passes after the fix.
AI Disclosure
PR Checklist
type(scope): description