Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc): getblocktemplate coinbase outputs order #9272

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(rpc): getblocktemplate coinbase outputs order #9272

wants to merge 5 commits into from

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Feb 18, 2025 •
edited by conradoplg
Loading

Motivation

In #8099 we realized zcashd always put miner reward output as the first output of the coinbase.

This PR copy that behaviour for the config debug_like_zcashd mode of Zebra mining.

Close #8099

Solution

Make the miner reward transaction to appear first when using the Zebra getblocktemplate RPC method and the debug_like_zcashd flag is on (which is the default).

Tests

Existing rpc_getblocktemplate was updated to check the miner reward is the first coinbase output.

Snapshot tests were updated.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added A-rpc Area: Remote Procedure Call interfaces A-compatibility Area: Compatibility with other nodes or wallets, or standard rules P-Medium ⚡ A-block-explorer Area: Block Explorer labels Feb 18, 2025
@oxarbitrage oxarbitrage self-assigned this Feb 18, 2025
@oxarbitrage oxarbitrage requested a review from a team as a code owner February 18, 2025 22:27
@oxarbitrage oxarbitrage requested review from conradoplg and removed request for a team February 18, 2025 22:27
conradoplg
conradoplg approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@oxarbitrage
Copy link
Contributor Author

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 4, 2025

update

✅ Branch has been successfully updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

Assignees

@oxarbitrage oxarbitrage

Labels
A-block-explorer Area: Block Explorer A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Place the output with the miner's address first in the coinbase tx
4 participants
@oxarbitrage @mpguerra @conradoplg @gustavovalverde