change(ci): Remove check for custom configs from GCP deployments #9280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upbqdn
added
C-bug
github-actions
bot
added
the
C-trivial
upbqdn
changed the title
test-zebra-conf-path
upbqdn
requested review from
conradoplg and
gustavovalverde
and removed request for
a team and
conradoplg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
test-zebra-conf-pathcheck incd-deploy-nodes-gcp.ymltries to configure Zebra running in a Docker container with a custom config file. However, it always fails because the container doesn't contain the file as it is built for theruntimetarget and contains only files needed in production. This test used to falsely pass because the entrypoint script used to create a new config file on the fly if the specified one was missing. We have the same check for a Docker container built for theteststarget insub-ci-unit-tests-docker.yml. This check works as intended because those containers contain the custom config file.Solution
test-zebra-conf-pathfromcd-deploy-noes-gcp.yml.An alternative solution would be to move the custom config file to the container, but that would require a lot more work, and I thought it wasn't worth it since we test the same functionality elsewhere.
Tests
N/A
PR Author's Checklist