-
Notifications
You must be signed in to change notification settings - Fork 132
change(rpc): Update getaddressbalance
RPC to return received
field
#9295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zebra-state/src/service/finalized_state/disk_format/transparent.rs
Outdated
Show resolved
Hide resolved
55b3602
to
deff106
Compare
944f8be
to
65fcd68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Just FYI @arya2 I pushed a small fix to the RPC serialization test to pass CI (I looked into it to see why I was failing and noticed it was simple to fix)
Thank you. @mpguerra, the last change looks good to me if you could re-approve. It adds the received field to the raw json that I forgot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved conversations and approved based on @conradoplg 's last approval
Motivation
Updates the
getaddressbalance
RPC to accept either a single address string or a list of them to match zcashd, and adds thereceived
field on the method's response.Closes #8452.
Closes #9463.
Depends-On: #9539.
Solution
received
field, and adds an in-place format upgrade,AddressStrings
as aVec
with one item, andreceived
field to thegetaddressbalance
RPC output.Tests
This PR still needs a manual test to check that the output matches zcashd.
The changes to the RPC should be covered by existing snapshot tests.
PR Checklist
C-exclude-from-changelog
label.