add(mining): Restore internal miner #9311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
added
C-testing
upbqdn
approved these changes
Mar 10, 2025
Comment on lines
+168
to
+169
| // If we got any solutions, try submitting them, because the new template might just | ||
| // contain some extra transactions. Mining extra transactions is optional. |
There was a problem hiding this comment.
Is this comment related to the code?
Suggested change
| // If we got any solutions, try submitting them, because the new template might just | |
| // contain some extra transactions. Mining extra transactions is optional. |
| // Restore the code when conditions are met. https://github.com/ZcashFoundation/zebra/issues/8183 | ||
| /// Returns `true` if the `nonce` and `solution` in `header` meet the difficulty threshold. | ||
| /// | ||
| /// Assumes that the difficulty threshold in the header is valid. |
There was a problem hiding this comment.
Suggested change
| /// Assumes that the difficulty threshold in the header is valid. | |
| /// # Panics | |
| /// | |
| /// - If `header` contains an invalid difficulty threshold. |
|
@mergify requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
|
@mergify refresh |
✅ Pull request refreshed |
|
@mergify rebase |
✅ Nothing to do for rebase action |
|
@arya2 you'll have to rebase this one manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to restore the experimental internal Testnet miner to run a Zebra-only Testnet with a published release.
Refresh of #8906.
Closes #8183.
Solution
Tests
Manually tested and experimental
Follow-up Work
PR Checklist
C-exclude-from-changeloglabel.