fix(docker): add default CMD to test stage in Dockerfile #9334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the container using docker-compose without explicitly providing a command, the entrypoint.sh script was attempting to execute `exec_as_user` with no arguments, resulting in a gosu error: ``` exec_as_user exec gosu 10001:10001 Usage: gosu user-spec command [args] ``` By adding `CMD ["cargo", "test"]` to the test stage in the Dockerfile, we ensure a default command is available for the entrypoint script to execute, preventing the gosu error when no command is explicitly provided. This fix allows `docker-compose.test.yml` to run successfully without needing to specify a command in the service definition.
gustavovalverde
added
C-bug
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsThis rule is failing.Requirement based on the presence of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When running the container using docker-compose without explicitly
providing a command, the entrypoint.sh script was attempting to execute
exec_as_userwith no arguments, resulting in a gosu error:Depends-On: #9333
Solution
By adding
CMD ["cargo", "test"]to the test stage in the Dockerfile, we ensure a default command is available for the entrypoint script to execute, preventing thegosuerror when no command is explicitly provided.This fix allows
docker-compose.test.ymlto run successfully without needing to specify a command in the service definition.Tests
There are no unit tests validating this, but running
docker compose -f docker/docker-compose.test.yml up --buildwill trigger it (without this PR).PR Checklist
C-exclude-from-changeloglabel.