-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote ReadStateService #9338
Draft
idky137
wants to merge
14
commits into
ZcashFoundation:main
Choose a base branch
from
idky137:remote_read_state_service_2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remote ReadStateService #9338
idky137
wants to merge
14
commits into
ZcashFoundation:main
from
idky137:remote_read_state_service_2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead_state_service_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opens the
ReadStateService
to remote use, as detailed in #9337.ReadStateService
. #9337Motivation
Zebra’s ReadStateService currently only allows local access, limiting its integration with external tools and remote debugging. Enabling remote access would streamline workflows, simplify testing, and support scalable, decentralized deployments—fostering a more modular and community-friendly Zcash ecosystem.
Solution
ReadRequest
andReadResponse
.NetworkKind
into defaultNetwork
type to avoid serialising whole Network.Display
andFromStr
forTransactionLocation
andOutputLocation
and uses for serialisation.remote_state_call
RPC to Zebra's JsonRPC server.RemoteStateRpc
trait to methods.rs and implements forRpcIml
.RemoteStateService
as endpoint to new remote functionality.RemoteStateService
struct to service.rs.tower::Service
for equivalent functionality to theReasdStateService
.NOTE: This feature has been added under the "remote_read_state_service" feature flag, this could be removed if this functionality should be enabled by default.
NOTE 2: This feature is now ready for review but is built on zcash/librustzcash#1745. For that reason I have left as draft until that PR lands.
Tests
Currently no new tests have been added, this is largely due to struggling to work out where / how tests should be added for this feature. I am happy to add any tests that are required.
Currently this code is tested in Zaino in the following PR: zingolabs/zaino#247.
Specifications & References
Follow-up Work
PR Checklist
C-exclude-from-changelog
label.