Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Transaction::V6 variants only #9339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aphelionz
Copy link

Motivation + Solution

On a recent call with @conradoplg and @arya2, we decided to try this out to make the NSM and ZSA PRs more managable.

This PR only adds the Transaction::V6 enum variant and then satisfies the compiler. The variant and its respective match arms and array members are feature-flagged under tx_v6.

Tests

  • cargo test --workspace locally

Follow-up Work

If this approach is suitable, I can do NetworkUpgrade::Nu7 as well.

PR Checklist

  • The PR name is suitable for the release notes.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.
  • If the PR shouldn't be in the release notes, it has the
    C-exclude-from-changelog label.

@aphelionz aphelionz requested review from a team as code owners March 20, 2025 18:27
@aphelionz aphelionz requested review from oxarbitrage and removed request for a team March 20, 2025 18:27
@mpguerra mpguerra requested review from conradoplg and removed request for oxarbitrage March 25, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant