fix(web): restore favicon, header logo, and PWA manifest dropped by the cutover#820
Merged
Conversation
…— replace placeholder glyph with BrandLogo (cherry-pick 1b02156; HomeView import re-resolved onto master)
…m BrandLogo — cutover dropped the legacy icons (empty tab icon, no manifest); 192/512/maskable PNGs + SVG, theme-color; prod-build spec guards manifest+icons 200
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #819. The M05 cutover (
hosting.public→web/dist) dropped the app's icon/brand assets that the legacyapp/build shipped. This restores them — all verified200on the static build:<link rel="icon">at all, so browsers requested/favicon.ico(404) and showed an empty tab icon. Adds the canonicalfavicon-128x128.png+ icon links (cherry-pick2295c1c).BrandLogocomponent and wires it intoAppMenu+HomeView(cherry-pick1b02156,HomeViewimport re-resolved onto master).start_url/display/theme_color→ never truly installable). This adds a real web app manifest (manifest.webmanifest) + 192/512/maskable PNG icons and an SVG icon, all rendered from theBrandLogoartwork, plustheme-color.How
rewrite/web-foundation(the two commits never reached master).BrandLogo's inline SVG viarsvg-convert(vector → crisp 192/512). SVG sources checked in (web/public/zenuml-logo*.svg)./, display standalone, theme#2e94d4).Test plan
pnpm -C web build→ favicon,manifest.webmanifest,icon-192/512,icon-maskable-512,zenuml-logo.svgall emitted todist;index.htmlcarries the icon + manifest links.npx playwright test production-build --project=chromium→ 5/5 green (new test asserts the favicon link, the manifest is valid JSON, has 192+512 PNGs, and every declared icon resolves 200).pnpm -C web typecheck→ clean.src/changes).Out of scope (not requested)
/ZenUML_Sequence_Diagram_addon_help.html(still 404; no external link found).Files
web/index.html,web/public/manifest.webmanifest,web/public/{favicon-128x128,icon-192,icon-512,icon-maskable-512}.png,web/public/zenuml-logo{,-maskable}.svgweb/src/ui/BrandLogo.tsx,web/src/ui/index.ts,web/src/components/header/AppMenu.tsx,web/src/components/home/HomeView.tsxe2e/tests/production-build.spec.js