Skip to content

Comments

Add build helper script for Pet Bond DLL#4

Open
ZeroXPatch wants to merge 1 commit intomainfrom
codex/create-pet-bond-skill-for-stardew-valley-nrareh
Open

Add build helper script for Pet Bond DLL#4
ZeroXPatch wants to merge 1 commit intomainfrom
codex/create-pet-bond-skill-for-stardew-valley-nrareh

Conversation

@ZeroXPatch
Copy link
Owner

Summary

  • add a build-release helper script to compile the mod and zip the output for easy installation
  • document the one-command build and zip workflow in the Pet Bond build guide

Testing

  • Not run (dotnet tooling not available in container)

Codex Task

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +125 to +129
this.Icon = IconFactory.CreateSkillIcon();
this.SkillsPageIcon = IconFactory.CreatePageIcon();
this.ExperienceBarColor = Color.HotPink;
this.ExtraLevelUpInfo = BuildExtraLevelInfo();
this.Professions = BuildProfessions();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Wire professions to level-up choices

The SpaceCore skill constructor only populates this.Professions and never registers any ProfessionsForLevels pairs. Without those mappings, SpaceCore won’t present a profession choice UI at levels 5/10 and the IDs checked throughout PetBondFeatureManager never get added to farmer.professions, so none of the profession-based buffs or jobs can ever activate when the player levels the skill.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant