This repository was archived by the owner on Mar 10, 2021. It is now read-only.
Always draw debug physics with linewidth 1#22
Open
idbrii wants to merge 1 commit intoa327ex:masterfrom
Open
Conversation
Don't let user width leak into physics debug draw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't let user width leak into physics debug draw. Drawing with a larger line width looks bad (at least it did on my 1080p grid-based game, maybe at super high res you might want a thicker line?).
Currently, users need to set the line width before calling draw. This makes that not necessary. Setup to match how we set colour. If you think it's more useful for users to control the width, go ahead and close.