Skip to content

sync: port upstream sidebar v2 default, Stop button, and late polish (#5554–#5677) - #220

Merged
cursor[bot] merged 28 commits into
mainfrom
codex/sync-20260808-l6-sidebar-default-a13c
Aug 8, 2026
Merged

sync: port upstream sidebar v2 default, Stop button, and late polish (#5554–#5677)#220
cursor[bot] merged 28 commits into
mainfrom
codex/sync-20260808-l6-sidebar-default-a13c

Conversation

@aaditagrawal

Copy link
Copy Markdown
Owner

Summary

Layer 6 of the 2026-08-08 upstream sync stack. Ports Stop-while-pending, Legacy features fold (pingdotgg#5664), sidebar v2 as the default sidebar (pingdotgg#5672), GitHub PR-status rate-limit fix, delayed reconnect warnings, simple typography terminal sizing, and background-subagent reaper safety (pingdotgg#5677).

Stacked on #219 (codex/sync-20260808-l5-mobile-pins-a13c).

Fork adapts

  • #5672: delete SidebarV2.tsx / promote upstream renamed Sidebar.tsx, but keep fork title-regeneration failure toasts + context-menu failure labels.
  • #5664: bridge fork-only apps/web/src/appSettings.ts local enableAssistantStreaming ↔ unified enableLegacyTokenStreaming.
  • Preserve ChatView rate-limit panel through ChatView merges.

Test plan

  • vp check + vp run typecheck green
  • Default sidebar is v2; legacy sidebar still available via setting
  • Title regeneration failure still toasts / labels in context menu
  • Rate-limit panel still present in ChatView
  • Stop button shows while input is pending

Stack

  1. sync: port upstream server settle, tunnel/update safety, and early web polish (#5482–#5486) #215 L1 → main
  2. sync: port upstream pagination, reconnect settle, and Claude subagent safety (#5556–#5573) #216 L2 → L1
  3. sync: port upstream plan fold and per-device provider settings (#5558–#5580) #217 L3 → L2
  4. sync: port upstream theme library, Done/Woke, and runtime mode (#5226–#5440) #218 L4 → L3
  5. sync: port upstream mobile UX, pin ordering, browser history, and sidebar polish (#5415–#5633) #219 L5 → L4
  6. This PR L6 → L5
  7. L7 (ours-merge ancestry) → L6
Open in Web Open in Cursor 

@cursor
cursor Bot force-pushed the codex/sync-20260808-l6-sidebar-default-a13c branch from 234380d to 7093c2d Compare August 8, 2026 07:24
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 492510ae-dbba-4e01-90be-c251913346d5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). labels Aug 8, 2026
@cursor
cursor Bot force-pushed the codex/sync-20260808-l6-sidebar-default-a13c branch 4 times, most recently from 83ca7ab to 42375ff Compare August 8, 2026 07:33
StoneCotton and others added 21 commits August 8, 2026 07:38
Co-authored-by: codex <codex@users.noreply.github.com>
(cherry picked from commit af281c9)
(cherry picked from commit bfc69e4)

Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Keep the MOBILE_APP_VERSION helper; only the fallback default changes.

Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
CI frozen-lockfile install failed because apps/web still resolved
@clerk/clerk-js@6.25.12 after the catalog moved to 6.25.13.

Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
t3dotgg and others added 7 commits August 8, 2026 07:39
…res (pingdotgg#5664)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…ngdotgg#5673)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
…bagents (pingdotgg#5677)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
@cursor
cursor Bot force-pushed the codex/sync-20260808-l5-mobile-pins-a13c branch from b00ad89 to 041e872 Compare August 8, 2026 07:39
@cursor
cursor Bot force-pushed the codex/sync-20260808-l6-sidebar-default-a13c branch from 42375ff to ad7de88 Compare August 8, 2026 07:39
@aaditagrawal
aaditagrawal marked this pull request as ready for review August 8, 2026 07:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad7de883b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if (pendingAction) {
return (
<div className={cn("flex items-center justify-end", compact ? "gap-1.5" : "gap-2")}>
{isRunning ? renderStopGenerationButton(true) : null}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pass the running state to mobile pending actions

In the mobile web pending-input layouts, ChatComposer.tsx renders this component with isRunning={false} at lines 2747–2750 and 3030–3033, while the normal footer is hidden or omitted. Consequently, this new branch never renders the Stop button on a phone when an active turn is waiting for user input, leaving the user unable to interrupt the generation from that surface. Pass phase === "running" through those specialized mobile call sites as well.

Useful? React with 👍 / 👎.

Comment on lines +937 to +939
if (details.upstreamRef === null && (yield* isUnpublishedBranch(cwd, headContext))) {
return { latest: null, headContext };
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep looking up PRs after remote refs are pruned

When a merged or closed PR's head branch is deleted remotely and a fetch prunes the corresponding tracking ref, this condition misclassifies the local branch as never published and returns latest: null without querying the provider. git fetch -h documents --prune as “prune remote-tracking branches no longer on remote,” so these refs are not durable evidence that a branch never reached the host. The successful null result also replaces the last-known PR state, causing the merged/closed badge and its sidebar lifecycle signal to disappear after pruning.

Useful? React with 👍 / 👎.

Comment on lines -9 to -10
export const Route = createFileRoute("/settings/beta")({
component: SettingsBetaRoute,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Redirect the retired beta settings URL

Deleting this route without retaining a redirect breaks existing bookmarks, browser-history entries, and externally shared links to /settings/beta, even though the settings themselves still exist under /settings/general. Those users now land on the router's unmatched-route state instead of the relocated controls; keep a lightweight route that redirects the old path to /settings/general.

Useful? React with 👍 / 👎.

/>
</SettingsSection>

<LegacyFeaturesSection />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include all legacy toggles in Restore defaults

Now that LegacyFeaturesSection is part of the General page, its controls are covered by the page-level Restore defaults action, but useSettingsRestore neither detects nor resets planModeEnabled or legacySidebarEnabled. If either is the only non-default preference, the Restore defaults button is disabled; if other preferences are also changed, restoration reports success while these two toggles remain enabled. Add both fields to changedSettingLabels, its dependencies, and the reset patch.

Useful? React with 👍 / 👎.

@cursor
cursor Bot changed the base branch from codex/sync-20260808-l5-mobile-pins-a13c to main August 8, 2026 07:49
@cursor
cursor Bot merged commit d3a7415 into main Aug 8, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.