sync: port upstream sidebar v2 default, Stop button, and late polish (#5554–#5677) - #220
Conversation
234380d to
7093c2d
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
83ca7ab to
42375ff
Compare
(cherry picked from commit 33a03c8)
…pingdotgg#5582) (cherry picked from commit bd422fd)
Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit af281c9)
(cherry picked from commit bfc69e4) Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Keep the MOBILE_APP_VERSION helper; only the fallback default changes. Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
This reverts commit 83f7f8e.
CI frozen-lockfile install failed because apps/web still resolved @clerk/clerk-js@6.25.12 after the catalog moved to 6.25.13. Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
…res (pingdotgg#5664) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…ngdotgg#5673) Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
…bagents (pingdotgg#5677) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
b00ad89 to
041e872
Compare
42375ff to
ad7de88
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad7de883b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (pendingAction) { | ||
| return ( | ||
| <div className={cn("flex items-center justify-end", compact ? "gap-1.5" : "gap-2")}> | ||
| {isRunning ? renderStopGenerationButton(true) : null} |
There was a problem hiding this comment.
Pass the running state to mobile pending actions
In the mobile web pending-input layouts, ChatComposer.tsx renders this component with isRunning={false} at lines 2747–2750 and 3030–3033, while the normal footer is hidden or omitted. Consequently, this new branch never renders the Stop button on a phone when an active turn is waiting for user input, leaving the user unable to interrupt the generation from that surface. Pass phase === "running" through those specialized mobile call sites as well.
Useful? React with 👍 / 👎.
| if (details.upstreamRef === null && (yield* isUnpublishedBranch(cwd, headContext))) { | ||
| return { latest: null, headContext }; | ||
| } |
There was a problem hiding this comment.
Keep looking up PRs after remote refs are pruned
When a merged or closed PR's head branch is deleted remotely and a fetch prunes the corresponding tracking ref, this condition misclassifies the local branch as never published and returns latest: null without querying the provider. git fetch -h documents --prune as “prune remote-tracking branches no longer on remote,” so these refs are not durable evidence that a branch never reached the host. The successful null result also replaces the last-known PR state, causing the merged/closed badge and its sidebar lifecycle signal to disappear after pruning.
Useful? React with 👍 / 👎.
| export const Route = createFileRoute("/settings/beta")({ | ||
| component: SettingsBetaRoute, |
There was a problem hiding this comment.
Redirect the retired beta settings URL
Deleting this route without retaining a redirect breaks existing bookmarks, browser-history entries, and externally shared links to /settings/beta, even though the settings themselves still exist under /settings/general. Those users now land on the router's unmatched-route state instead of the relocated controls; keep a lightweight route that redirects the old path to /settings/general.
Useful? React with 👍 / 👎.
| /> | ||
| </SettingsSection> | ||
|
|
||
| <LegacyFeaturesSection /> |
There was a problem hiding this comment.
Include all legacy toggles in Restore defaults
Now that LegacyFeaturesSection is part of the General page, its controls are covered by the page-level Restore defaults action, but useSettingsRestore neither detects nor resets planModeEnabled or legacySidebarEnabled. If either is the only non-default preference, the Restore defaults button is disabled; if other preferences are also changed, restoration reports success while these two toggles remain enabled. Add both fields to changedSettingLabels, its dependencies, and the reset patch.
Useful? React with 👍 / 👎.
Summary
Layer 6 of the 2026-08-08 upstream sync stack. Ports Stop-while-pending, Legacy features fold (pingdotgg#5664), sidebar v2 as the default sidebar (pingdotgg#5672), GitHub PR-status rate-limit fix, delayed reconnect warnings, simple typography terminal sizing, and background-subagent reaper safety (pingdotgg#5677).
Stacked on #219 (
codex/sync-20260808-l5-mobile-pins-a13c).Fork adapts
#5672: deleteSidebarV2.tsx/ promote upstream renamedSidebar.tsx, but keep fork title-regeneration failure toasts + context-menu failure labels.#5664: bridge fork-onlyapps/web/src/appSettings.tslocalenableAssistantStreaming↔ unifiedenableLegacyTokenStreaming.Test plan
vp check+vp run typecheckgreenStack