Conversation
There was a problem hiding this comment.
Pull request overview
Adds an interactive option when generating an abapGit CLAS artifact to also generate a corresponding test include file.
Changes:
- Adjusts formatting for several VS Code API calls in
create.ts. - Prompts the user during CLAS creation to optionally create a test include.
- Creates a
.testclasses.abapinclude file when the user confirms.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| await createFile(dir, uriABAP, dataABAP); | ||
|
|
||
| const createTestClass = await vscode.window.showQuickPick( | ||
| [{ label: "yes" }, | ||
| { label: "no" }], |
There was a problem hiding this comment.
The new “Add test class include?” prompt runs unconditionally after createFile(dir, uriABAP, ...). If the class files already exist, createFile returns early (after showing an error) and the user will still be prompted and may create a .testclasses.abap include even though the class wasn’t actually created in this run. Consider having createFile return a boolean (created vs. skipped) and only showing the QuickPick (and/or creating the include) when the class creation succeeded.
There was a problem hiding this comment.
I'd like to avoid changing the interface of createFile for this PR
|
@larshp after class was created, user will be asked whether test class include should be added. Fixed choice yes | no: 
any thoughts? |
|
looks nice I'm out of town this week, so will get back to this PR, remind me if I forget 😅 |
|
thanks |
|
published as 0.0.27 |
added option to create testclass include when creating CLAS artifact. After class was created, user is asked whether he wants to add an include for testclasses.