Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for toggling the abapGit WITH_UNIT_TESTS flag in generated CLAS XML, and verifies the behavior via the web extension test suite.
Changes:
- Refactors CLAS XML generation into a new exported helper (
buildClasXml) and conditionally injects<WITH_UNIT_TESTS>X</WITH_UNIT_TESTS>. - Updates CLAS creation flow to ask whether to include unit tests before generating the XML, and reuses the flag for creating the
.testclassesinclude. - Adds web extension tests covering presence/absence of the
WITH_UNIT_TESTSelement.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/web/create.ts |
Extracts CLAS XML generation into buildClasXml and conditionally emits WITH_UNIT_TESTS, driven by a QuickPick choice. |
src/web/test/suite/extension.test.ts |
Adds tests asserting the generated CLAS XML includes/omits WITH_UNIT_TESTS based on the flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.