WebUSB Demo and BOS Platform support#101
Closed
riggs wants to merge 9 commits intoabcminiuser:masterfrom
Closed
Conversation
…t they are, fundamentally.
Author
|
Some further notes: I based the demo on GenericHID, because that's what the device I migrated to WebUSB was based on. Also, I'm creating an library/extension to WebUSB to allow for easy HID device migration (by adding another platform descriptor & WebUSB descriptor), at which point a GenericHID-based demo is appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly different approach to WebUSB than #91 that is more in the style of the rest of LUFA.
Personally, I think it's more readable (and, thus, maintainable) as well, but that just opinion. The tradeoff is a slight memory performance hit (unless someone else wants to figure out which magic combination of pgm_read_byte calls is necessary to deal with memcpy from nested structs in PROGMEM).
I isolated WebUSBDevice.h & BOSDescriptors.h in order to allow them to be baked back into the framework code, though I couldn't figure out how to actually hook them in. Also, there's code in Descriptors.c to generate the return bytes for a BOS request that might make more sense in BOSDescriptors.c (which doesn't exist), but I left it where it is for now because I know that works.