Fix issues with getCommentStrings for Atom 1.23+#10
Open
danielhickman wants to merge 1 commit intoabe33:masterfrom
Open
Fix issues with getCommentStrings for Atom 1.23+#10danielhickman wants to merge 1 commit intoabe33:masterfrom
getCommentStrings for Atom 1.23+#10danielhickman wants to merge 1 commit intoabe33:masterfrom
Conversation
|
Yup, without this atom-figlet cannot be used anymore, please pull those PR in @abe33 |
|
@abe33 Ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It now calls
editor.getScopedSettingsDelegate().getCommentStrings(scope)ifgetCommentStringsdoesn't exist. See: hydrogen/pull/1093I continued to use the slightly more verbose
?operator because it seemed slightly better than a short circuit assignment and wrapped it across multiple lines because the API seems to have changed a bunch.I tested it in 1.23 and 1.21. Fixes #9