-
Notifications
You must be signed in to change notification settings - Fork 2
Bump plugin-support to 0.3.0 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughSwift package dependencies are updated across manifest and lock files. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
AblyLiveObjects.xcworkspace/xcshareddata/swiftpm/Package.resolved(1 hunks)Package.resolved(1 hunks)Package.swift(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.swift
📄 CodeRabbit inference engine (.cursor/rules/swift.mdc)
**/*.swift: Specify an explicit access control level (SwiftLint explicit_acl) for all declarations in Swift code (tests are exempt)
When extending a type, put the access level on the extension declaration rather than on each member (tests are exempt)
Prefer implicit .init(...) when the type can be inferred in initializer expressions
Prefer enum case shorthand (.caseName) when the type can be inferred
For JSONValue or WireValue, prefer using literal syntax via ExpressibleBy*Literal where possible
Prefer Swift raw string literals for JSON strings instead of escaping double quotes
When an array literal begins with an initializer expression, place the initializer on the line after the opening bracket
Files:
Package.swift
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: Example app, macOS (Xcode 16.3)
- GitHub Check: Example app, iOS (Xcode 16.3)
- GitHub Check: Xcode, tvOS (Xcode 16.3)
- GitHub Check: Example app, tvOS (Xcode 16.3)
- GitHub Check: Xcode, iOS (Xcode 16.3)
- GitHub Check: Xcode, macOS (Xcode 16.3)
- GitHub Check: SPM (Xcode 16.3)
- GitHub Check: Xcode,
releaseconfiguration, iOS (Xcode 16.3) - GitHub Check: Xcode,
releaseconfiguration, tvOS (Xcode 16.3) - GitHub Check: Xcode,
releaseconfiguration, macOS (Xcode 16.3) - GitHub Check: SPM,
releaseconfiguration (Xcode 16.3) - GitHub Check: Generate code coverage
🔇 Additional comments (4)
Package.resolved (1)
2-2: Lock file update is expected.The originHash change reflects updates to the dependency graph in Package.swift.
AblyLiveObjects.xcworkspace/xcshareddata/swiftpm/Package.resolved (1)
2-2: Workspace lock file is consistent with package lock file.The dependency updates in the workspace-specific Package.resolved correctly mirror the changes in the root Package.resolved.
Also applies to: 9-9, 17-18
Package.swift (2)
23-24: TODO reminder: Unpin ably-cocoa before release.The ably-cocoa dependency remains pinned to a specific revision. Ensure this TODO is tracked and addressed before the next release.
28-29: Successfully transitioned to version-based constraint.The change from revision-based to
exact: "0.3.0"aligns with the PR objective. The use ofexactis appropriate for 0.x versions, as explained in the comment.
| "location" : "https://github.com/ably/ably-cocoa", | ||
| "state" : { | ||
| "revision" : "4a394311f110b9a67b372934346605740f0e7a53" | ||
| "revision" : "cb8ea1890ed15af871ae5798dbd3e80480d8801c" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
ably-cocoa-plugin-support 0.3.0 release
💡 Result:
I couldn't find a 0.3.0 release. The ably-cocoa-plugin-support package's latest published version is 0.2.0 (released 2025-09-29), per the Swift Package Registry and Swift Package Index. [1][2]. The ably-cocoa package also depends on ably-cocoa-plugin-support 0.2.0. [3]
Sources:
- Swift Package Registry — ably-cocoa-plugin-support (0.2.0). [1]
- Swift Package Index — ably-cocoa-plugin-support (shows 0.2.0). [2]
- ably-cocoa package listing (shows dependency on ably-cocoa-plugin-support 0.2.0). [3]
🌐 Web query:
ably-cocoa commit cb8ea1890ed15af871ae5798dbd3e80480d8801c
💡 Result:
Commit cb8ea1890ed15af871ae5798dbd3e80480d8801c (ably/ably-cocoa)
- Message: "Bump plugin-support to 0.3.0". [1]
- Author: lawrence-forooghian (committed on the ably/ably-cocoa repo). [1]
- Files changed: Package.swift (updated ably-cocoa-plugin-support from a pinned revision to "0.3.0") and Package.resolved (lockfile update). +3 / −3 lines total. [1]
- Parent: commit 44b2199. [1]
Source: GitHub commit page for cb8ea1890ed15af871ae5798dbd3e80480d8801c. [1][2]
References
[1] GitHub — ably/ably-cocoa commit cb8ea18.
[2] ably/ably-cocoa repository.
Verify ably-cocoa-plugin-support version 0.3.0 is released before merging.
The commit cb8ea1890ed15af871ae5798dbd3e80480d8801c exists in ably-cocoa (with message "Bump plugin-support to 0.3.0"), but version 0.3.0 of ably-cocoa-plugin-support is not currently published in the Swift Package Registry or Swift Package Index. The latest published version is 0.2.0 (released 2025-09-29). Ensure that version 0.3.0 has been officially released or tagged before updating Package.resolved, and verify compatibility with the current ably-cocoa dependency.
|
You can ignore this one |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.