Skip to content

Conversation

@lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented Jan 15, 2026

The current ones don't seem to be available any more.

Summary by CodeRabbit

  • Chores
    • Updated iOS and tvOS target runtimes to newer releases for improved platform compatibility.
    • Bumped the Xcode toolchain used in build and CI workflows to a newer version to ensure up-to-date build tooling and smoother integration.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Walkthrough

Bumped iOS and tvOS simulator runtime versions in Platform.swift, updated Xcode toolchain version in the CI workflow, and aligned the GenerateMatrices Xcode tooling entry to the new version. No control-flow or public API changes.

Changes

Cohort / File(s) Summary
Platform runtime version updates
Sources/BuildTool/Platform.swift
Updated destinationStrategy runtimes: iOS from "iOS-18-4""iOS-26-2"; tvOS from "tvOS-18-4""tvOS-26-2" (deviceType unchanged)
CI workflow Xcode version bump
.github/workflows/check.yaml
Updated Xcode toolchain version references from 16.316.4 across setup steps and related comments
Matrix generation Xcode tooling
Sources/BuildTool/BuildTool.swift
Changed GenerateMatrices Xcode tooling mapping: xcodeVersion value 16.316.4

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through code and CI skies,

bumped runtimes, watched versions rise.
From sixteen-three to sweet sixteen-four,
and simulators leap to twenty-six and more.
A little tweak, a steady cheer—updates done, let's forward steer!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Bump CI simulator OS versions' directly aligns with the main changes: updating simulator OS versions from iOS-18-4/tvOS-18-4 to iOS-26-2/tvOS-26-2 and Xcode from 16.3 to 16.4.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 26.2-simulators


📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2a3e22f and c4bf274.

📒 Files selected for processing (3)
  • .github/workflows/check.yaml
  • Sources/BuildTool/BuildTool.swift
  • Sources/BuildTool/Platform.swift
🚧 Files skipped from review as they are similar to previous changes (1)
  • Sources/BuildTool/Platform.swift
🧰 Additional context used
📓 Path-based instructions (2)
**/*.swift

📄 CodeRabbit inference engine (.cursor/rules/swift.mdc)

**/*.swift: Specify an explicit access control level (SwiftLint explicit_acl) for all declarations in Swift code (tests are exempt)
When extending a type, put the access level on the extension declaration rather than on each member (tests are exempt)
Prefer implicit .init(...) when the type can be inferred in initializer expressions
Prefer enum case shorthand (.caseName) when the type can be inferred
For JSONValue or WireValue, prefer using literal syntax via ExpressibleBy*Literal where possible
Prefer Swift raw string literals for JSON strings instead of escaping double quotes
When an array literal begins with an initializer expression, place the initializer on the line after the opening bracket

Files:

  • Sources/BuildTool/BuildTool.swift
Sources/**/*.swift

📄 CodeRabbit inference engine (.cursor/rules/testing.mdc)

For testsOnly_ property declarations, do not add generic explanatory comments (their meaning is understood)

Files:

  • Sources/BuildTool/BuildTool.swift
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: Example app, tvOS (Xcode 16.4)
  • GitHub Check: Xcode, release configuration, tvOS (Xcode 16.4)
  • GitHub Check: Xcode, release configuration, iOS (Xcode 16.4)
  • GitHub Check: Xcode, macOS (Xcode 16.4)
  • GitHub Check: Example app, iOS (Xcode 16.4)
  • GitHub Check: Example app, macOS (Xcode 16.4)
  • GitHub Check: Xcode, tvOS (Xcode 16.4)
  • GitHub Check: Xcode, iOS (Xcode 16.4)
  • GitHub Check: Xcode, release configuration, macOS (Xcode 16.4)
  • GitHub Check: SPM, release configuration (Xcode 16.4)
  • GitHub Check: SPM (Xcode 16.4)
  • GitHub Check: Generate code coverage
🔇 Additional comments (6)
.github/workflows/check.yaml (5)

23-26: LGTM! Consistent Xcode version bump across CI workflow.

The Xcode version is correctly updated to 16.4 in the lint job, with the comment appropriately reflecting the new minimum version threshold.


52-55: Commented section updated consistently.

The commented-out spec-coverage job also has its Xcode version updated to maintain consistency when this section is eventually re-enabled.


71-74: LGTM! Matrix generation uses updated Xcode version.

This ensures the generate-matrices job uses the same Xcode version that will be emitted in the matrix output from BuildTool.swift.


152-155: LGTM! Code coverage job updated.


229-232: LGTM! Documentation build uses updated Xcode version.

All hardcoded Xcode version references in this workflow are now consistently set to 16.4, and the matrix-based jobs will inherit the version from GenerateMatrices. The changes are well-coordinated across the codebase.

Sources/BuildTool/BuildTool.swift (1)

151-155: Xcode version bump is valid.

The update to "16.4" is confirmed as a legitimate Xcode version (released May 28, 2025). This local variable assignment doesn't require explicit access control and complies with the Swift coding guidelines.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot temporarily deployed to staging/pull/110/AblyLiveObjects January 15, 2026 11:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/110/AblyLiveObjects January 15, 2026 17:45 Inactive
The current ones don't seem to be available any more.
@lawrence-forooghian lawrence-forooghian merged commit 3c54331 into main Jan 16, 2026
18 checks passed
@lawrence-forooghian lawrence-forooghian deleted the 26.2-simulators branch January 16, 2026 09:29
@lawrence-forooghian
Copy link
Collaborator Author

cc @maratal I've merged this one to unblock #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants