-
Notifications
You must be signed in to change notification settings - Fork 19
PubSub packages split and related documentation #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ttypic
wants to merge
4
commits into
main
Choose a base branch
from
feature/pdr-091-pubsub-device-server-packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2eadaf4
Add the IO.Ably.PubSub.Device and IO.Ably.PubSub.Server packages
ttypic ceed637
Cover the PubSub packages with specs
ttypic 435fdfd
Pack the PubSub packages alongside the core one
ttypic 05a2eba
Document the PubSub device and server packages
ttypic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd"> | ||
| <metadata> | ||
| <id>ably.io.pubsub.device</id> | ||
| <version>$version$</version> | ||
| <title>Ably Pub/Sub Device</title> | ||
| <authors>Martin Georgiev, Yavor Ivanov, Jack Rutherford, Tom Kirby-Green, Sachin Shinde</authors> | ||
| <owners>Ably Real-time Ltd</owners> | ||
| <license type="expression">Apache-2.0</license> | ||
| <projectUrl>https://github.com/ably/ably-dotnet</projectUrl> | ||
| <icon>icon.png</icon> | ||
| <readme>README.md</readme> | ||
| <requireLicenseAcceptance>false</requireLicenseAcceptance> | ||
| <description>Ably Pub/Sub client for applications running on an end-user device - mobile, desktop, browser or embedded. Adds PubSubDevice.CreateClient as the entry point, over the client and API of the ably.io SDK. See https://www.ably.io for more info.</description> | ||
| <releaseNotes>https://github.com/ably/ably-dotnet/releases</releaseNotes> | ||
| <copyright>©2025 Ably Real-time Ltd</copyright> | ||
| <tags>ably realtime messaging websocket pubsub presence device client dotnet csharp maui netstandard xamarin unity</tags> | ||
| <repository type="git" url="https://github.com/ably/ably-dotnet.git" branch="main" /> | ||
| <language /> | ||
| <dependencies> | ||
|
|
||
| <group> | ||
| <!-- TODO: Find a way to dynamically update this dependency. | ||
| The PubSub packages release in lockstep with the core, so the lower bound is the | ||
| version they ship alongside; bump it with every release. --> | ||
| <dependency id="ably.io" version="[1.2.19,2.0.0]" /> | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| </group> | ||
|
|
||
| </dependencies> | ||
| </metadata> | ||
| <files> | ||
| <file src="..\src\IO.Ably.PubSub.Device\bin\$configuration$\netstandard2.0\IO.Ably.PubSub.Device.dll" target="lib\netstandard2.0" /> | ||
| <file src="..\src\IO.Ably.PubSub.Device\bin\$configuration$\netstandard2.0\IO.Ably.PubSub.Device.pdb" target="lib\netstandard2.0" /> | ||
| <file src="..\src\IO.Ably.PubSub.Device\bin\$configuration$\netstandard2.0\IO.Ably.PubSub.Device.xml" target="lib\netstandard2.0" /> | ||
| <file src="..\README.md" target="README.md" /> | ||
| <file src="..\images\logo.png" target="icon.png" /> | ||
| </files> | ||
| </package> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd"> | ||
| <metadata> | ||
| <id>ably.io.pubsub.server</id> | ||
| <version>$version$</version> | ||
| <title>Ably Pub/Sub Server</title> | ||
| <authors>Martin Georgiev, Yavor Ivanov, Jack Rutherford, Tom Kirby-Green, Sachin Shinde</authors> | ||
| <owners>Ably Real-time Ltd</owners> | ||
| <license type="expression">Apache-2.0</license> | ||
| <projectUrl>https://github.com/ably/ably-dotnet</projectUrl> | ||
| <icon>icon.png</icon> | ||
| <readme>README.md</readme> | ||
| <requireLicenseAcceptance>false</requireLicenseAcceptance> | ||
| <description>Ably Pub/Sub client for applications running on a server - ASP.NET, Azure, workers or console apps. Adds PubSubServer.CreateRealtimeClient and PubSubServer.CreateHttpClient as the entry points, over the clients and API of the ably.io SDK. See https://www.ably.io for more info.</description> | ||
| <releaseNotes>https://github.com/ably/ably-dotnet/releases</releaseNotes> | ||
| <copyright>©2025 Ably Real-time Ltd</copyright> | ||
| <tags>ably realtime messaging websocket pubsub presence server backend dotnet csharp aspnet azure netstandard</tags> | ||
| <repository type="git" url="https://github.com/ably/ably-dotnet.git" branch="main" /> | ||
| <language /> | ||
| <dependencies> | ||
|
|
||
| <group> | ||
| <!-- TODO: Find a way to dynamically update this dependency. | ||
| The PubSub packages release in lockstep with the core, so the lower bound is the | ||
| version they ship alongside; bump it with every release. --> | ||
| <dependency id="ably.io" version="[1.2.19,2.0.0]" /> | ||
| </group> | ||
|
|
||
| </dependencies> | ||
| </metadata> | ||
| <files> | ||
| <file src="..\src\IO.Ably.PubSub.Server\bin\$configuration$\netstandard2.0\IO.Ably.PubSub.Server.dll" target="lib\netstandard2.0" /> | ||
| <file src="..\src\IO.Ably.PubSub.Server\bin\$configuration$\netstandard2.0\IO.Ably.PubSub.Server.pdb" target="lib\netstandard2.0" /> | ||
| <file src="..\src\IO.Ably.PubSub.Server\bin\$configuration$\netstandard2.0\IO.Ably.PubSub.Server.xml" target="lib\netstandard2.0" /> | ||
| <file src="..\README.md" target="README.md" /> | ||
| <file src="..\images\logo.png" target="icon.png" /> | ||
| </files> | ||
| </package> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the device installation command.
The section lists both companion packages, but the only executable installation example installs
ably.io.pubsub.server. Adddotnet add package ably.io.pubsub.deviceso device users can follow the documented installation path directly.🤖 Prompt for AI Agents