-
Notifications
You must be signed in to change notification settings - Fork 24
fix: Incorrect parsing of index_urls in requirements.txt #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ukaj as tests in CI should be fixed now, can you please rebase your PR? |
@ukaj do you mind to add a test too? And is the issue coming from the pip-requirements-parser library? |
@heliocastro, could you take care of this? |
Signed-off-by: ukaj <[email protected]>
48882b0
to
a89fcee
Compare
Thanks @ukaj for the update. Now @pombredanne or @TG1999, can you please approve the workflow? |
Hi, @pombredanne and @TG1999 from Bosch side we would also be very interested in a solution, as we currently have several customers who are affected. It would be amazing if you approve the workflow. Thank you very much! |
@kerstin-bosch @sschuberth workflow has been approved but tests are failing. I am looking into how can I fix the failing tests here. |
Hi @TG1999, did you have a chance to look at the tests already? Thanks in advance! |
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
@kerstin-bosch I have updated the tests, I have also added the missing test for this PR which caused some delay. Merging this soon! Thanks for your patience. |
@TG1999: That's really great, thank you very much! :) Are you planning a release soon? |
Before this change, the index_urls variable contained incorrectly parsed values:
After this fix, index_urls is parsed as:
Fixes #173