Skip to content

fix: Incorrect parsing of index_urls in requirements.txt #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025

Conversation

ukaj
Copy link

@ukaj ukaj commented Mar 11, 2025

Before this change, the index_urls variable contained incorrectly parsed values:

('https://pypi.org/simple', 'h', 't', 't', 'p', 's', ':', '/', '/', 'p', 'y', 'p', 'i', '.', 'o', 'r', 'g', '/', 's', 'i', 'm', 'p', 'l', 'e')

After this fix, index_urls is parsed as:

('https://pypi.org/simple', 'https://pypi.org/simple')

Fixes #173

@sschuberth
Copy link
Contributor

@ukaj as tests in CI should be fixed now, can you please rebase your PR?

@pombredanne
Copy link
Member

@ukaj do you mind to add a test too? And is the issue coming from the pip-requirements-parser library?

@sschuberth
Copy link
Contributor

@ukaj as tests in CI should be fixed now, can you please rebase your PR?

@heliocastro, could you take care of this?

@ukaj ukaj force-pushed the fix/unsupported_url_scheme branch from 48882b0 to a89fcee Compare April 17, 2025 08:58
@sschuberth
Copy link
Contributor

Thanks @ukaj for the update. Now @pombredanne or @TG1999, can you please approve the workflow?

@kerstin-bosch
Copy link

Hi, @pombredanne and @TG1999 from Bosch side we would also be very interested in a solution, as we currently have several customers who are affected. It would be amazing if you approve the workflow. Thank you very much!

@TG1999
Copy link
Contributor

TG1999 commented Apr 17, 2025

@kerstin-bosch @sschuberth workflow has been approved but tests are failing. I am looking into how can I fix the failing tests here.

@kerstin-bosch
Copy link

Hi @TG1999, did you have a chance to look at the tests already? Thanks in advance!

TG1999 added 2 commits April 29, 2025 13:30
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Copy link
Contributor

TG1999 commented Apr 29, 2025

@kerstin-bosch I have updated the tests, I have also added the missing test for this PR which caused some delay. Merging this soon! Thanks for your patience.

@TG1999 TG1999 merged commit e7baa00 into aboutcode-org:main Apr 29, 2025
6 of 9 checks passed
@kerstin-bosch
Copy link

@TG1999: That's really great, thank you very much! :) Are you planning a release soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unsupported URL scheme" exception when analyzing requirements file
5 participants