Fix #141 - Fix IPv6 handling in Via header for IPv6 with zero compression#142
Open
teerapap wants to merge 1 commit intoaboutsip:masterfrom
Open
Fix #141 - Fix IPv6 handling in Via header for IPv6 with zero compression#142teerapap wants to merge 1 commit intoaboutsip:masterfrom
teerapap wants to merge 1 commit intoaboutsip:masterfrom
Conversation
Changes in detail * Implement `consumeHost()` method in `SipParser` loosely based on RFC 3261 * Fix typo in method name `consumeSentBye()` -> `consumeSentBy()` * Refactor `consumeVia()` method to make use of `consumeSentBy()` * Refactor `consumeSentBy()` method to make use of `consumeHost()` * Improve `consumeGenericParam()` method to loosely handle host in addition to token * Add unit tests for IPv6 address with zero compression for Via header
Contributor
Author
|
Just found that some other tests fails. Will resubmit the pull request again |
Contributor
Author
|
False alarm. It does not relate to this pull request changes. Some tests failed because I was using JDK17 running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in detail
consumeHost()method inSipParserloosely based on RFC 3261consumeSentBye()->consumeSentBy()consumeVia()method to make use ofconsumeSentBy()consumeSentBy()method to make use ofconsumeHost()consumeGenericParam()method to loosely handle host in addition to token