Use a standard structure for tags for CMS Kit #23924
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the HTML markup for tag display in the CMS Kit to use a proper unordered list (<ul>) structure instead of loose elements. This provides better semantic HTML and improves accessibility for screen readers.
- Wraps tags in a
<ul>element with flexbox styling for layout - Encapsulates each tag in a
<li>element with margin spacing - Maintains existing styling and functionality for both linked and non-linked tags
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
modules/cms-kit/src/Volo.CmsKit.Public.Web/Pages/CmsKit/Shared/Components/Tags/Default.cshtml
Outdated
Show resolved
Hide resolved
| @if (Model.Tags != null) | ||
| { | ||
| <ul class="d-flex flex-wrap"> | ||
| @foreach (var tag in Model.Tags) |
There was a problem hiding this comment.
Corrected spelling of 'standart' to 'standard' in PR title.
enisn
reviewed
Oct 9, 2025
| { | ||
| if (Model.UrlFormat.IsNullOrWhiteSpace()) | ||
| { | ||
| <li class="me-1"> |
There was a problem hiding this comment.
Instead of manually adding margin in elements with me-1, I suggest using gap-1 in the .d-flex container
<ul class="d-flex flex-wrap gap-1">
Co-authored-by: Copilot <[email protected]>
enisn
changed the title
MansurBesleney
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves vs-internal-issue-#7448
Checklist