Fix the type signature of skip_log_prefix to preserve the decorated function's return type. - #420
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_947607875
branch
5 times, most recently
from
July 21, 2026 08:55
19099c8 to
cc72fec
Compare
…unction's return type. The type variable for the decorated function should be bounded so that the exact signature is captured, otherwise the argument and return types end up as Any. This not only weakens type checking, but when decorating a NoReturn function, it messes up the type checker's understanding of the control flow. PiperOrigin-RevId: 951340806
copybara-service
Bot
force-pushed
the
test_947607875
branch
from
July 21, 2026 09:00
cc72fec to
d949076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the type signature of skip_log_prefix to preserve the decorated function's return type.
The type variable for the decorated function should be bounded so that the exact signature is captured, otherwise the argument and return types end up as Any. This not only weakens type checking, but when decorating a NoReturn function, it messes up the type checker's understanding of the control flow.