SMQ-2604 - Change PAT repo implementation #2680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindh123
requested changes
Feb 5, 2025
|
@nyagamunene Please address comments @arvindh123 left. |
arvindh123
requested changes
Feb 10, 2025
nyagamunene
force-pushed
the
MG-2604
branch
2 times, most recently
from
32b153e to
d5d9b8e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2680 +/- ##
==========================================
- Coverage 42.08% 35.34% -6.75%
==========================================
Files 341 238 -103
Lines 47488 38794 -8694
==========================================
- Hits 19987 13710 -6277
+ Misses 25318 24000 -1318
+ Partials 2183 1084 -1099 ☔ View full report in Codecov by Sentry. |
arvindh123
requested changes
Feb 13, 2025
dborovcanin
reviewed
Feb 14, 2025
auth/pat.go
Outdated
Comment on lines
238
to
243
| PatId string | ||
| OptionalDomainId string `json:"optional_domain_id,omitempty"` | ||
| EntityType EntityType `json:"entity_type,omitempty"` | ||
| EntityId string `json:"entity_id,omitempty"` | ||
| Operation Operation `json:"operation,omitempty"` |
There was a problem hiding this comment.
Why do we have a scope this complex? Can we have it embedded entity types and operations only?
arvindh123
requested changes
Feb 18, 2025
arvindh123
reviewed
Feb 18, 2025
arvindh123
reviewed
Feb 18, 2025
arvindh123
reviewed
Feb 18, 2025
arvindh123
reviewed
Feb 18, 2025
arvindh123
reviewed
Feb 18, 2025
arvindh123
reviewed
Feb 18, 2025
arvindh123
reviewed
Feb 18, 2025
arvindh123
requested changes
Feb 18, 2025
arvindh123
requested changes
Feb 18, 2025
arvindh123
requested changes
Feb 18, 2025
arvindh123
reviewed
Feb 18, 2025
arvindh123
requested changes
Feb 18, 2025
auth/cache/pat.go
Outdated
Comment on lines
32
to
36
| key := GenerateKey(sc.PatID, sc.OptionalDomainID, sc.EntityType, sc.Operation, sc.EntityID) | ||
| if err := pc.client.Set(ctx, key, true, pc.duration).Err(); err != nil { | ||
| return errors.Wrap(repoerr.ErrCreateEntity, err) | ||
| } |
There was a problem hiding this comment.
Lets add entityID to key and value as only True
pc.client.Set(ctx, key, true, 0).Err()
There was a problem hiding this comment.
Lets add entityID to key and value as only
Truepc.client.Set(ctx, key, true, 0).Err()
The pc.duration is the time it takes before it expires in the RAM. By setting it to 0 it will never expire. Should this be the case?
There was a problem hiding this comment.
Let's have pc.Duration, Don't set to 0, I just gave an example to for key
arvindh123
reviewed
Feb 19, 2025
arvindh123
reviewed
Feb 19, 2025
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes