Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMQ-2609 - Remove DomainUserID encoding from session and authn #2688

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

felixgateru
Copy link
Contributor

What type of PR is this?

This is a refactor as it remove DomainUserID encoding.

What does this do?

This pr removes DomainUserID encodinh and makes all authorization on entities to be performed with userID.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, I have updated tests.

Did you document any new/modified feature?

No,

Notes

None

@felixgateru felixgateru marked this pull request as ready for review February 10, 2025 14:44
@felixgateru felixgateru requested a review from a team as a code owner February 10, 2025 14:44
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 9.21053% with 69 lines in your changes missing coverage. Please review.

Project coverage is 36.46%. Comparing base (da6e3e1) to head (47452d5).

Files with missing lines Patch % Lines
groups/middleware/authorization.go 0.00% 19 Missing ⚠️
domains/middleware/authorization.go 0.00% 17 Missing ⚠️
channels/middleware/authorization.go 0.00% 16 Missing ⚠️
clients/middleware/authorization.go 0.00% 12 Missing ⚠️
journal/middleware/authorization.go 0.00% 2 Missing ⚠️
ws/handler.go 0.00% 2 Missing ⚠️
channels/private/service.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2688      +/-   ##
==========================================
- Coverage   42.08%   36.46%   -5.63%     
==========================================
  Files         341      246      -95     
  Lines       47488    40977    -6511     
==========================================
- Hits        19987    14941    -5046     
+ Misses      25318    24898     -420     
+ Partials     2183     1138    -1045     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SuperAdmin could not perform actions over entities
2 participants