Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMQ-2705 - Add list groups with no parent group #2708

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felixgateru
Copy link
Contributor

What type of PR is this?

This is a feature becasue it adds the functionality to list groups which do not have a parent group

What does this do?

This pr adds a query parameter to ListGroups endpoint to be able to list groups which do not have a parent group.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes

Did you document any new/modified feature?

No

Notes

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.70%. Comparing base (7667eee) to head (41c2377).

Files with missing lines Patch % Lines
groups/api/http/decode.go 80.00% 2 Missing and 1 partial ⚠️
groups/postgres/groups.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
- Coverage   42.08%   41.70%   -0.39%     
==========================================
  Files         341       24     -317     
  Lines       47488     5076   -42412     
==========================================
- Hits        19987     2117   -17870     
+ Misses      25318     2792   -22526     
+ Partials     2183      167    -2016     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixgateru felixgateru marked this pull request as ready for review February 13, 2025 14:16
@felixgateru felixgateru requested a review from a team as a code owner February 13, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: List groups with no parent group
1 participant