feat: open external sidebar links in new tab#3388
feat: open external sidebar links in new tab#3388jarrensj wants to merge 3 commits intoacademicpages:masterfrom
Conversation
Add target="_blank" and rel="noopener noreferrer" to all external links in the author sidebar
|
I have mixed feelings about |
all good, just felt like I kept clicking sidebar social links and then losing the original page I was on so I was hoping it would open a new tab instead but I think whatever you think is best for the template works for me! I normally just anticipate it opening in a new tab so I don't often then I need to intentionally right-click to open into a new tab. We can close this PR though if you think it's not needed! |
|
Let me know if I should close this (or keep but remove noopener) and I can get that done! |
|
I'm inclined to keep it, but we should make sure that if we are doing it for the side bar that other spots with social media links behave the same. Likewise the redundant code should be cleaned up just to keep things up to date with web standards. |
- Add target="_blank" rel="noopener noreferrer" to social media links in footer and share buttons - Apply same attributes to academic, repository, and documentation links
Add target="_blank" and rel="noopener noreferrer" to all external links in the author sidebar