Skip to content

Mhk concerto setup :: Améliorations et de Corrections Mineurs et/ou amélioratives#1178

Open
MohamedKhattat wants to merge 8 commits intoaccordproject:mainfrom
MohamedKhattat:mhk-concerto-setup
Open

Mhk concerto setup :: Améliorations et de Corrections Mineurs et/ou amélioratives#1178
MohamedKhattat wants to merge 8 commits intoaccordproject:mainfrom
MohamedKhattat:mhk-concerto-setup

Conversation

@MohamedKhattat
Copy link
Copy Markdown

  1. Fixes avec justificatifs
    Les modifications build:types dans les 4 package.json (concerto-core, concerto-cto, concerto-util, concerto-vocabulary) ajoutent --target ES2015 --skipLibCheck — c'est une correction légitime pour résoudre des problèmes de compatibilité TypeScript lors de la génération des .d.ts.
  2. Nettoyage cohérent des .d.ts
    Supprimer les imports cassés (BaseException, BaseFileException, FileDownloader, ModelFile, ModelManager) depuis @accordproject/concerto-util dans les fichiers de types est logique si ces imports causaient des erreurs de résolution circulaire ou de build.
  3. Le test-browser.html est une bonne initiative
    Tester Concerto côté browser est aligné avec les projets GSoC 2026 mentionnant la migration vers Rust/WASM et les outils web.

@mttrbrts
Copy link
Copy Markdown
Member

@MohamedKhattat Thanks for your contribution. We've just merged a major update that migrates the whole project to TypeScript. Can you rebase your branch, and review the changes, please?

@MohamedKhattat
Copy link
Copy Markdown
Author

MohamedKhattat commented Apr 21, 2026 via email

@MohamedKhattat
Copy link
Copy Markdown
Author

MohamedKhattat commented Apr 21, 2026 via email

@mttrbrts
Copy link
Copy Markdown
Member

Thanks for this contribution! Before we can review, please resolve the merge conflicts with the base branch.

git fetch origin main
git rebase origin/main
# Resolve conflicts
git push --force-with-lease

Once the conflicts are resolved, we'll proceed with the review.


This comment was generated by AI on behalf of @mttrbrts.

@MohamedKhattat
Copy link
Copy Markdown
Author

MohamedKhattat commented Apr 27, 2026 via email

…t-browser.html

Signed-off-by: Mohamed Habib Khattat - ARABSOFT <76012233+MohamedKhattat@users.noreply.github.com>
Signed-off-by: Mohamed Habib Khattat - ARABSOFT <76012233+MohamedKhattat@users.noreply.github.com>
Signed-off-by: Mohamed Habib Khattat - ARABSOFT <76012233+MohamedKhattat@users.noreply.github.com>
@MohamedKhattat
Copy link
Copy Markdown
Author

MohamedKhattat commented Apr 27, 2026 via email

@MohamedKhattat
Copy link
Copy Markdown
Author

MohamedKhattat commented Apr 27, 2026 via email

- Load concerto-core bundle directly in browser
- Parse real CTO models from the project (readme, sample namespaces)
- Introspect declarations and properties via ModelManager/Introspector
- Validate JSON data against Concerto schema
- Fix: use getModelFiles() for namespace resolution (browser compat)
- Fix: remove addCTOModel filename arg to avoid path.basename error
- Fix: correct malformed gitignore entries

Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
Mohamed Habib Khattat added 4 commits April 27, 2026 19:40
- Add browser/i18n/ with en.json, fr.json, tn.json translation files
- Implement language switcher with RTL support for Arabic
- Add .cto file upload zone with FileReader API
- Uploaded schemas are parsed and introspected inline

Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants