Mhk concerto setup :: Améliorations et de Corrections Mineurs et/ou amélioratives#1178
Open
MohamedKhattat wants to merge 8 commits intoaccordproject:mainfrom
Open
Mhk concerto setup :: Améliorations et de Corrections Mineurs et/ou amélioratives#1178MohamedKhattat wants to merge 8 commits intoaccordproject:mainfrom
MohamedKhattat wants to merge 8 commits intoaccordproject:mainfrom
Conversation
197e4b6 to
7feea1d
Compare
Member
|
@MohamedKhattat Thanks for your contribution. We've just merged a major update that migrates the whole project to TypeScript. Can you rebase your branch, and review the changes, please? |
Author
|
------------------------------
Hi,
Thank you for the heads-up and for merging the TypeScript migration; that's
a significant step forward for the project.
I will instantly rebase my branch on the updated main and review my changes
carefully.
Best regards, Mohamed Habib Khattat
Data Scientist
…On Tue, 21 Apr 2026 at 12:32, Matt Roberts ***@***.***> wrote:
*mttrbrts* left a comment (accordproject/concerto#1178)
<#1178?email_source=notifications&email_token=ASD5VSKZHZ3H7KIH2KHKUCT4W5E3HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRYG44DENZRGUYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4287827150>
@MohamedKhattat <https://github.com/MohamedKhattat> Thanks for your
contribution. We've just merged a major update that migrates the whole
project to TypeScript. Can you rebase your branch, and review the changes,
please?
—
Reply to this email directly, view it on GitHub
<#1178?email_source=notifications&email_token=ASD5VSKZHZ3H7KIH2KHKUCT4W5E3HA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRYG44DENZRGUYKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4287827150>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASD5VSLZHFW6MCCNQ4MOONT4W5E3HAVCNFSM6AAAAACXIFUV2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEOBXHAZDOMJVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
7feea1d to
b66c822
Compare
Author
|
hello,
After completing the rebase and tests, reply to the GitHub comment with:
***@***.*** Rebase completed successfully. Branch now aligned with
upstream/main after TypeScript migration. Build and tests pass. Browser
bundle loads correctly on localhost:54321 (introduced to just ping a
specific test visual endpoint). No conflicts encountered.
the lastest opend PR, it's yet to be ready for review.
Mohamed Khattat
|
04f5eb7 to
2641def
Compare
Member
|
Thanks for this contribution! Before we can review, please resolve the merge conflicts with the base branch. git fetch origin main
git rebase origin/main
# Resolve conflicts
git push --force-with-leaseOnce the conflicts are resolved, we'll proceed with the review. This comment was generated by AI on behalf of @mttrbrts. |
Author
|
Hello *mttrbrts, *
*Mentor, I've just followed your review. I appreciate your clear briefs.*
*I would verify and fix the issue. *
…On Sun, 26 Apr 2026 at 23:22, Matt Roberts ***@***.***> wrote:
*mttrbrts* left a comment (accordproject/concerto#1178)
<#1178 (comment)>
Thanks for this contribution! Before we can review, please resolve the
merge conflicts with the base branch.
git fetch origin main
git rebase origin/main# Resolve conflicts
git push --force-with-lease
Once the conflicts are resolved, we'll proceed with the review.
------------------------------
*This comment was generated by AI on behalf of @mttrbrts
<https://github.com/mttrbrts>.*
—
Reply to this email directly, view it on GitHub
<#1178 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASD5VSL5YNMC2L4IQ7567RL4XZ42DAVCNFSM6AAAAACXIFUV2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMRTGAZTAOJWHE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ASD5VSLWTX2TYYEC76A7IGL4XZ42DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGMYDGMBZGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/ASD5VSKQVISSP4PCEZYB5MD4XZ42DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGMYDGMBZGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…t-browser.html Signed-off-by: Mohamed Habib Khattat - ARABSOFT <76012233+MohamedKhattat@users.noreply.github.com>
Signed-off-by: Mohamed Habib Khattat - ARABSOFT <76012233+MohamedKhattat@users.noreply.github.com>
Signed-off-by: Mohamed Habib Khattat - ARABSOFT <76012233+MohamedKhattat@users.noreply.github.com>
2641def to
745fcb6
Compare
Author
|
Hello mentors,
I have rebased mhk-concerto-setup onto the latest upstream main (v4.0.1),
resolved all conflicts, and pushed the updated branch.
I also improved the browser-based schema explorer (test-browser.html) that
loads concerto-core directly in the browser, parses real CTO models from
the project, and validates JSON data, confirming browser compatibility as
initially proposed. Ready for your review:
github.com/MohamedKhattat/concerto-GSoC/tree/mhk-concerto-setup.
Best regards,
Mohamed Habib Khattat
On Mon, 27 Apr 2026 at 17:35, Mouhamed Habib KHATTAT <
***@***.***> wrote:
… Hello *mttrbrts, *
*Mentor, I've just followed your review. I appreciate your clear briefs.*
*I would verify and fix the issue. *
On Sun, 26 Apr 2026 at 23:22, Matt Roberts ***@***.***>
wrote:
> *mttrbrts* left a comment (accordproject/concerto#1178)
> <#1178 (comment)>
>
> Thanks for this contribution! Before we can review, please resolve the
> merge conflicts with the base branch.
>
> git fetch origin main
> git rebase origin/main# Resolve conflicts
> git push --force-with-lease
>
> Once the conflicts are resolved, we'll proceed with the review.
> ------------------------------
>
> *This comment was generated by AI on behalf of @mttrbrts
> <https://github.com/mttrbrts>.*
>
> —
> Reply to this email directly, view it on GitHub
> <#1178 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ASD5VSL5YNMC2L4IQ7567RL4XZ42DAVCNFSM6AAAAACXIFUV2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMRTGAZTAOJWHE>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/ASD5VSLWTX2TYYEC76A7IGL4XZ42DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGMYDGMBZGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
> and Android
> <https://github.com/notifications/mobile/android/ASD5VSKQVISSP4PCEZYB5MD4XZ42DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGMYDGMBZGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
> Download it today!
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Author
|
[image: image.png]
On Mon, 27 Apr 2026 at 19:09, Mouhamed Habib KHATTAT <
***@***.***> wrote:
… Hello mentors,
I have rebased mhk-concerto-setup onto the latest upstream main (v4.0.1),
resolved all conflicts, and pushed the updated branch.
I also improved the browser-based schema explorer (test-browser.html) that
loads concerto-core directly in the browser, parses real CTO models from
the project, and validates JSON data, confirming browser compatibility as
initially proposed. Ready for your review:
github.com/MohamedKhattat/concerto-GSoC/tree/mhk-concerto-setup.
Best regards,
Mohamed Habib Khattat
On Mon, 27 Apr 2026 at 17:35, Mouhamed Habib KHATTAT <
***@***.***> wrote:
> Hello *mttrbrts, *
>
> *Mentor, I've just followed your review. I appreciate your clear briefs.*
> *I would verify and fix the issue. *
>
> On Sun, 26 Apr 2026 at 23:22, Matt Roberts ***@***.***>
> wrote:
>
>> *mttrbrts* left a comment (accordproject/concerto#1178)
>> <#1178 (comment)>
>>
>> Thanks for this contribution! Before we can review, please resolve the
>> merge conflicts with the base branch.
>>
>> git fetch origin main
>> git rebase origin/main# Resolve conflicts
>> git push --force-with-lease
>>
>> Once the conflicts are resolved, we'll proceed with the review.
>> ------------------------------
>>
>> *This comment was generated by AI on behalf of @mttrbrts
>> <https://github.com/mttrbrts>.*
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#1178 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/ASD5VSL5YNMC2L4IQ7567RL4XZ42DAVCNFSM6AAAAACXIFUV2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGMRTGAZTAOJWHE>
>> .
>> Triage notifications, keep track of coding agent tasks and review pull
>> requests on the go with GitHub Mobile for iOS
>> <https://github.com/notifications/mobile/ios/ASD5VSLWTX2TYYEC76A7IGL4XZ42DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGMYDGMBZGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
>> and Android
>> <https://github.com/notifications/mobile/android/ASD5VSKQVISSP4PCEZYB5MD4XZ42DA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMZSGMYDGMBZGY42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
>> Download it today!
>> You are receiving this because you were mentioned.Message ID:
>> ***@***.***>
>>
>
|
- Load concerto-core bundle directly in browser - Parse real CTO models from the project (readme, sample namespaces) - Introspect declarations and properties via ModelManager/Introspector - Validate JSON data against Concerto schema - Fix: use getModelFiles() for namespace resolution (browser compat) - Fix: remove addCTOModel filename arg to avoid path.basename error - Fix: correct malformed gitignore entries Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
69face1 to
cbd8181
Compare
added 4 commits
April 27, 2026 19:40
- Add browser/i18n/ with en.json, fr.json, tn.json translation files - Implement language switcher with RTL support for Arabic - Add .cto file upload zone with FileReader API - Uploaded schemas are parsed and introspected inline Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
Signed-off-by: Mohamed Habib Khattat <mohamedhabib.khattat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Les modifications build:types dans les 4 package.json (concerto-core, concerto-cto, concerto-util, concerto-vocabulary) ajoutent --target ES2015 --skipLibCheck — c'est une correction légitime pour résoudre des problèmes de compatibilité TypeScript lors de la génération des .d.ts.
Supprimer les imports cassés (BaseException, BaseFileException, FileDownloader, ModelFile, ModelManager) depuis @accordproject/concerto-util dans les fichiers de types est logique si ces imports causaient des erreurs de résolution circulaire ou de build.
Tester Concerto côté browser est aligné avec les projets GSoC 2026 mentionnant la migration vers Rust/WASM et les outils web.