Missile Guidance - Add support for CBA disposable launchers on SACLOS#11329
Open
some-evil-kitty wants to merge 2 commits intoacemod:masterfrom
Open
Missile Guidance - Add support for CBA disposable launchers on SACLOS#11329some-evil-kitty wants to merge 2 commits intoacemod:masterfrom
some-evil-kitty wants to merge 2 commits intoacemod:masterfrom
Conversation
Contributor
Author
|
uhhh cc @TheCandianVendingMachine because missiles are her child |
PabstMirror
approved these changes
Apr 1, 2026
PabstMirror
reviewed
Apr 2, 2026
Oh good shout, I forgot that there are no cba-added vanilla disposables. Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Contributor
Author
|
Good suggestion! Forgot that CBA doesn't actually add any disposables from vanilla stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Resolve #11328
I'm still not sure on the exact implementation, but I can't think of another way that isn't incredibly hacky. Added overhead per frame is something like 0.0003 ms so IMO it's worth the cost for the readability.