Medical Gui - Prevent firing on sudden menu close#11344
Open
PabstMirror wants to merge 1 commit intomasterfrom
Open
Medical Gui - Prevent firing on sudden menu close#11344PabstMirror wants to merge 1 commit intomasterfrom
PabstMirror wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
0.5 seconds seems like a long time to me but if it's only on sudden closures and not all closures then it's probably fine. |
Contributor
|
Mean visual reaction time of some med students was like 0.25s so 0.5s seems reasonable to account for the Arma old-timers. Could make it a slider setting, 0 to disable and up to 1s? |
Contributor
|
Might be good to extend this to after waking up from uncon as well? |
DartRuffian
reviewed
Apr 12, 2026
Comment on lines
+20
to
+21
| if (!alive ace_player) exitWith {}; | ||
| if (!isNil QGVAR(temporaryBlockFireEH)) exitWith {}; // if in-progress temporary block already exists, don't create another one |
Contributor
There was a problem hiding this comment.
I know this can be simplified but don't have brain power rn
Suggested change
| if (!alive ace_player) exitWith {}; | |
| if (!isNil QGVAR(temporaryBlockFireEH)) exitWith {}; // if in-progress temporary block already exists, don't create another one | |
| // If in-progress temporary block already exists, don't create another one | |
| if (!alive ace_player || !isNil QGVAR(temporaryBlockFireEH)) exitWith {}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives very brief block of mouse firing when the medical menu closes because of condition
(not on intentional closure from hitting escape)
e.g. treating patient, clicking on action, they move a little bit away, and you click and shoot them☹️
could make setting if needed