Skip to content

[tools - update_event_files] Change references to annotation #9665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skarya22 opened this issue Mar 4, 2025 · 2 comments · Fixed by #9697
Closed

[tools - update_event_files] Change references to annotation #9665

skarya22 opened this issue Mar 4, 2025 · 2 comments · Fixed by #9697
Assignees
@jeffersoncasimir
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Area: EEG Issue or PR related to electroencephalography Difficuly: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...)

Comments

@skarya22
Copy link
Contributor

skarya22 commented Mar 4, 2025

Change annotation to events in accordance to BIDS.

References to electrophysioannotations should really be electrophysioevents, the file name is update_annotation_files, it should be update_event_files etc.
@skarya22 skarya22 added 27.0.0 - Bugs Bugs Found in LORIS 27 testing Area: EEG Issue or PR related to electroencephalography Difficuly: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...) labels Mar 4, 2025
@christinerogers
Copy link
Contributor

@skarya22 Does this mean we missed documentation changes when doing #9032 ?

@skarya22
Copy link
Contributor Author

skarya22 commented Mar 5, 2025

@christinerogers I think it means that the documentation was updated but not the code? But yeah, it should've been done in that PR. Based on this convo in #Loris with @jeffersoncasimir
Image

@jeffersoncasimir jeffersoncasimir mentioned this issue Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffersoncasimir jeffersoncasimir

Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Area: EEG Issue or PR related to electroencephalography Difficuly: Trivial PR or issue whose implementation is obviously correct and no-risk (typo, formatting...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tools] Replace 'annotation' references in tools with 'events' jeffersoncasimir/Loris
3 participants
@christinerogers @jeffersoncasimir @skarya22