Skip to content

[tools] Replace 'annotation' references in tools with 'events' #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jeffersoncasimir
Copy link
Contributor

Closes #9665

@regisoc regisoc added the 27.0.0 - Bugs Bugs Found in LORIS 27 testing label Mar 25, 2025
@regisoc regisoc added this to the 27.0.0 milestone Mar 25, 2025
@skarya22 skarya22 self-assigned this Mar 27, 2025
@skarya22 skarya22 self-requested a review March 27, 2025 17:49
@skarya22
Copy link
Contributor

skarya22 commented Apr 7, 2025

@jeffersoncasimir I can't seem to get around this error for update_event_files, should I be able to run it?

PHP Warning:  fopen(/data-raisinbread/bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_events.tsv): Failed to open stream: Read-only file system in /var/www/loris/modules/electrophysiology_browser/php/models/electrophysioevents.class.inc on line 410

Warning: fopen(/data-raisinbread/bids_imports/Face13_BIDSVersion_1.1.0/sub-OTT167/ses-V1/eeg/sub-OTT167_ses-V1_task-faceO_events.tsv): Failed to open stream: Read-only file system in /var/www/loris/modules/electrophysiology_browser/php/models/electrophysioevents.class.inc on line 410

Copy link
Contributor

@skarya22 skarya22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except that I can't test update_event_files -- once confirmation received on that I will approve

@jeffersoncasimir
Copy link
Contributor Author

jeffersoncasimir commented Apr 7, 2025

/data-raisinbread/ is read-only and probably defined as the dataDirBasepath in the Config table or the project/config.xml file. This should ideally be tested on a copy of the data in a writeable location.

@skarya22
Copy link
Contributor

skarya22 commented Apr 7, 2025

@jeffersoncasimir I set my configuration module to use /data/raisinbread-copy
image

But for some reason the script is still using the old value :(
image

@jeffersoncasimir
Copy link
Contributor Author

jeffersoncasimir commented Apr 7, 2025

If this is what is expected, I would make sure that it is not being overridden in project/config.xml:
SELECT Value FROM Config JOIN ConfigSettings ON ConfigID = ConfigSettings.ID WHERE Name = 'dataDirBasepath';

Copy link
Contributor

@skarya22 skarya22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit dd1b1f5 into aces:main Apr 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tools - update_event_files] Change references to annotation
4 participants