-
Notifications
You must be signed in to change notification settings - Fork 182
[tools] Replace 'annotation' references in tools with 'events' #9697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools] Replace 'annotation' references in tools with 'events' #9697
Conversation
@jeffersoncasimir I can't seem to get around this error for update_event_files, should I be able to run it?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except that I can't test update_event_files -- once confirmation received on that I will approve
|
@jeffersoncasimir I set my configuration module to use But for some reason the script is still using the old value :( |
If this is what is expected, I would make sure that it is not being overridden in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #9665