Conversation
Contributor
|
@adamdaudrich What was the issue exactly? |
Contributor
Author
This PR corrects a language ambiguity in the sweet alert error throw. There are conditions established in the code for the file name and I felt that the error msg could be a little more obvious. |
Contributor
Author
|
The file size thing is a separate issue connected to environment as @ridz1208 pointed out. Try uploading on Pierre Rioux wuz here and that should not happen. |
Contributor
Contributor
Author
|
That's it for this one ! Merci |
Collaborator
|
@adamdaudrich this can't be merged because of a conflict, but since it's oging to main while you're rebasing it can you also make this compatible with the multilingual changes? |
91d0e00 to
6a77e52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Brief summary of changes
Testing instructions (if applicable)
Checkout this remote branch
npm run compile
Go to Clinical / Media
Enter :
MTL 023,V1,MRI Parameter Formin the fields.create a file named
ROM162_V2_bmi.mp4. Browse for it and hitUploadYou should see the following message:
Link(s) to related issue(s)