Skip to content

[media] upload tab#9731

Merged
driusan merged 4 commits intoaces:mainfrom
adamdaudrich:mediaUploadTab
Feb 9, 2026
Merged

[media] upload tab#9731
driusan merged 4 commits intoaces:mainfrom
adamdaudrich:mediaUploadTab

Conversation

@adamdaudrich
Copy link
Copy Markdown
Contributor

@adamdaudrich adamdaudrich commented Mar 25, 2025

Brief summary of changes

  • Have you updated related documentation? NO. Testing not technically fully done because i am getting a "file too large" error as well. I opened a separate issue for that.

Testing instructions (if applicable)

  • Checkout this remote branch

  • npm run compile

  • Go to Clinical / Media

  • Enter : MTL 023 , V1, MRI Parameter Form in the fields.

  • create a file named ROM162_V2_bmi.mp4 . Browse for it and hit Upload

You should see the following message:

Screenshot from 2025-03-21 13-01-06

  • Replicate this by selecting new fields and attempting to upload a non-corresponding file name.
  • Assert that the error message asks for the filename indicated in the fields.
  • Try adding a file formatted the same way with spaces instead of underscores. Assert that the file is accepted.

Link(s) to related issue(s)

  • Resolves # 9721 (Reference the issue this fixes, if any.)

@adamdaudrich adamdaudrich added Module: media PR or issue related to media module 27.0.0 - Bugs Bugs Found in LORIS 27 testing labels Mar 25, 2025
@GeorgeMurad
Copy link
Copy Markdown
Contributor

@adamdaudrich What was the issue exactly?

@adamdaudrich
Copy link
Copy Markdown
Contributor Author

@adamdaudrich What was the issue exactly?

This PR corrects a language ambiguity in the sweet alert error throw.

There are conditions established in the code for the file name and I felt that the error msg could be a little more obvious.

@adamdaudrich
Copy link
Copy Markdown
Contributor Author

The file size thing is a separate issue connected to environment as @ridz1208 pointed out. Try uploading on Pierre Rioux wuz here and that should not happen.

@GeorgeMurad
Copy link
Copy Markdown
Contributor

I see the message now. which makes sense. Is there anything else?

image

@adamdaudrich
Copy link
Copy Markdown
Contributor Author

That's it for this one ! Merci

Copy link
Copy Markdown
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan
Copy link
Copy Markdown
Collaborator

driusan commented Jan 28, 2026

@adamdaudrich this can't be merged because of a conflict, but since it's oging to main while you're rebasing it can you also make this compatible with the multilingual changes?

@github-actions github-actions Bot added the Language: Javascript PR or issue that update Javascript code label Feb 3, 2026
@driusan driusan merged commit c728e76 into aces:main Feb 9, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

27.0.0 - Bugs Bugs Found in LORIS 27 testing Language: Javascript PR or issue that update Javascript code Module: media PR or issue related to media module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants